NFC Spell out the return type of getUniqueDefaultBinding

steakhal · steakhal · commit 37cdde0dc277 · 2024-11-14T16:25:12.000+01:00
diff --git a/clang/lib/StaticAnalyzer/Core/RegionStore.cpp b/clang/lib/StaticAnalyzer/Core/RegionStore.cpp
@@ -2641,7 +2641,7 @@ std::optional<RegionBindingsRef> RegionStoreManager::tryBindSmallStruct(
   //   Direct [ 0..31]: Derived{Conj{}, w.width}
   //   Direct [32..63]: Derived{Conj{}, w.height}
   // Instead, we should just bind that Conjured value instead.
-  if (auto Val = getUniqueDefaultBinding(LCV)) {
+  if (std::optional<SVal> Val = getUniqueDefaultBinding(LCV)) {
     return B.addBinding(BindingKey::Make(R, BindingKey::Default), Val.value());
   }
 

Original file line number	Diff line number	Diff line change
`@@ -2641,7 +2641,7 @@ std::optional<RegionBindingsRef> RegionStoreManager::tryBindSmallStruct(`
`2641`	`2641`	`// Direct [ 0..31]: Derived{Conj{}, w.width}`
`2642`	`2642`	`// Direct [32..63]: Derived{Conj{}, w.height}`
`2643`	`2643`	`// Instead, we should just bind that Conjured value instead.`
`2644`		`- if (auto Val = getUniqueDefaultBinding(LCV)) {`
	`2644`	`+ if (std::optional<SVal> Val = getUniqueDefaultBinding(LCV)) {`
`2645`	`2645`	`return B.addBinding(BindingKey::Make(R, BindingKey::Default), Val.value());`
`2646`	`2646`	`}`
`2647`	`2647`