Skip to content

Commit 37daa19

Browse files
fixup! remove multiple render defs
1 parent ac9840b commit 37daa19

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

llvm/lib/Target/RISCV/RISCVGISel.td

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,13 @@ def GIAddrRegImm :
5050
GIComplexOperandMatcher<s32, "selectAddrRegImm">,
5151
GIComplexPatternEquiv<AddrRegImm>;
5252

53-
def GIVLOpS32 : GIComplexOperandMatcher<s32, "renderVLOp">,
54-
GIComplexPatternEquiv<VLOp>;
55-
def GIVLOpS64 : GIComplexOperandMatcher<s64, "renderVLOp">,
56-
GIComplexPatternEquiv<VLOp>;
53+
// FIXME: This is labelled as handling 's32', however the ComplexPattern it
54+
// refers to handles both i32 and i64 based on the HwMode. Currently this LLT
55+
// parameter appears to be ignored so this pattern works for both, however we
56+
// should add a LowLevelTypeByHwMode, and use that to define our XLenLLT instead
57+
// here.
58+
def GIVLOp : GIComplexOperandMatcher<s32, "renderVLOp">,
59+
GIComplexPatternEquiv<VLOp>;
5760

5861
// Convert from i32 immediate to i64 target immediate to make SelectionDAG type
5962
// checking happy so we can use ADDIW which expects an XLen immediate.

0 commit comments

Comments
 (0)