Do not serialize PlaceholderTypeConstraintInitialized if

hasPlaceholderTypeConstraint is false

Author: alejandro-alvarez-sonarsource

clang/lib/Serialization/ASTReaderDecl.cpp

@@ -2703,8 +2703,10 @@ void ASTDeclReader::VisitNonTypeTemplateParmDecl(NonTypeTemplateParmDecl *D) {
   // TemplateParmPosition.
   D->setDepth(Record.readInt());
   D->setPosition(Record.readInt());
-  if (Record.readBool()) // PlaceholderTypeConstraintInitialized
-    D->setPlaceholderTypeConstraint(Record.readExpr());
+  if (D->hasPlaceholderTypeConstraint()) {
+    if (Record.readBool()) // PlaceholderTypeConstraintInitialized
+      D->setPlaceholderTypeConstraint(Record.readExpr());
+  }
   if (D->isExpandedParameterPack()) {
     auto TypesAndInfos =
         D->getTrailingObjects<std::pair<QualType, TypeSourceInfo *>>();

clang/lib/Serialization/ASTWriterDecl.cpp

@@ -1993,11 +1993,14 @@ void ASTDeclWriter::VisitNonTypeTemplateParmDecl(NonTypeTemplateParmDecl *D) {
   // TemplateParmPosition.
   Record.push_back(D->getDepth());
   Record.push_back(D->getPosition());
-  Expr *TypeConstraint = D->getPlaceholderTypeConstraint();
-  Record.push_back(/*PlaceholderTypeConstraintInitialized=*/TypeConstraint !=
-                   nullptr);
-  if (TypeConstraint)
-    Record.AddStmt(TypeConstraint);
+
+  if (D->hasPlaceholderTypeConstraint()) {
+    Expr *TypeConstraint = D->getPlaceholderTypeConstraint();
+    Record.push_back(/*PlaceholderTypeConstraintInitialized=*/TypeConstraint !=
+                     nullptr);
+    if (TypeConstraint)
+      Record.AddStmt(TypeConstraint);
+  }
 
   if (D->isExpandedParameterPack()) {
     for (unsigned I = 0, N = D->getNumExpansionTypes(); I != N; ++I) {