Addressed review comments

Author: zahiraam

clang/include/clang/Basic/OpenMPKinds.def

@@ -278,7 +278,7 @@ OPENMP_DOACROSS_MODIFIER(source_omp_cur_iteration)
 OPENMP_THREADSET_KIND(omp_pool)
 OPENMP_THREADSET_KIND(omp_team)
 
-OPENMP_TRANSPARENT_KIND(omp_notimpex)
+OPENMP_TRANSPARENT_KIND(omp_not_impex)
 OPENMP_TRANSPARENT_KIND(omp_import)
 OPENMP_TRANSPARENT_KIND(omp_export)
 OPENMP_TRANSPARENT_KIND(omp_impex)

clang/lib/AST/OpenMPClause.cpp

@@ -2049,7 +2049,7 @@ void OMPClausePrinter::VisitOMPThreadsetClause(OMPThreadsetClause *Node) {
 void OMPClausePrinter::VisitOMPTransparentClause(OMPTransparentClause *Node) {
   OS << "transparent("
      << getOpenMPSimpleClauseTypeName(OMPC_transparent,
-                                      unsigned(Node->getTransparentKind()))
+                                      Node->getTransparentKind())
      << ")";
 }
 

clang/lib/Serialization/ASTReader.cpp

@@ -11682,8 +11682,7 @@ void OMPClauseReader::VisitOMPTransparentClause(OMPTransparentClause *C) {
   C->setLParenLoc(Record.readSourceLocation());
   SourceLocation TransparentKindLoc = Record.readSourceLocation();
   C->setTransparentKindLoc(TransparentKindLoc);
-  OpenMPTransparentKind TKind =
-      static_cast<OpenMPTransparentKind>(Record.readInt());
+  OpenMPTransparentKind TKind = Record.readEnum<OpenMPTransparentKind>();
   C->setTransparentKind(TKind);
 }
 

flang/include/flang/Parser/parse-tree.h

@@ -4862,7 +4862,7 @@ struct OmpToClause {
 // transparent-clause ->
 //    TRANSPARENT[(impex-type)]                     // since 6.0
 struct OmpTransparentClause {
-  ENUM_CLASS(TransparentPolicy, Omp_NotImpex, Omp_Import, Omp_Export, Omp_Impex)
+  ENUM_CLASS(TransparentPolicy, Omp_Not_Impex, Omp_Import, Omp_Export, Omp_Impex)
   WRAPPER_CLASS_BOILERPLATE(OmpTransparentClause, TransparentPolicy);
 };
 

flang/lib/Lower/OpenMP/Clauses.cpp

@@ -1506,7 +1506,7 @@ Transparent make(const parser::OmpClause::Transparent &inp,
   CLAUSET_ENUM_CONVERT( //
       convert, wrapped::TransparentPolicy, Transparent::TransparentPolicy,
       // clang-format off
-      MS(Omp_NotImpex, Omp_NotImpex)
+      MS(Omp_Not_Impex, Omp_Not_Impex)
       MS(Omp_Import, Omp_Import)
       MS(Omp_Export, Omp_Export)
       MS(Omp_Impex, Omp_Impex)

llvm/include/llvm/Frontend/OpenMP/ClauseT.h

@@ -1201,7 +1201,7 @@ struct ToT {
 // V6.0: [17.9.6] `transparent` clause
 template <typename T, typename I, typename E> //
 struct TransparentT {
-  ENUM(TransparentPolicy, Omp_NotImpex, Omp_Import, Omp_Export, Omp_Impex);
+  ENUM(TransparentPolicy, Omp_Not_Impex, Omp_Import, Omp_Export, Omp_Impex);
   using WrapperTrait = std::true_type;
   TransparentPolicy v;
 };