add testcases, don't consider type param inquiry as subobject

Author: kparzysz

flang/lib/Semantics/check-omp-structure.cpp

@@ -3044,7 +3044,7 @@ void OmpStructureChecker::CheckReductionObjects(
         if (!std::holds_alternative<parser::Name>(base.u)) {
           auto source{GetObjectSource(object)};
           context_.Say(source ? *source : GetContext().clauseSource,
-              "The base expression of an array element in %s clause must be an identifier"_err_en_US,
+              "The base expression of an array element or section in %s clause must be an identifier"_err_en_US,
               parser::ToUpperCaseLetters(getClauseName(clauseId).str()));
         }
       }
@@ -4013,11 +4013,13 @@ void OmpStructureChecker::Enter(const parser::OmpClause::Copyin &x) {
 void OmpStructureChecker::CheckStructureComponent(
     const parser::OmpObjectList &objects, llvm::omp::Clause clauseId) {
   auto CheckComponent{[&](const parser::Designator &designator) {
-    if (auto *desg{std::get_if<parser::DataRef>(&designator.u)}) {
-      if (auto *comp{parser::Unwrap<parser::StructureComponent>(*desg)}) {
-        context_.Say(comp->component.source,
-            "A variable that is part of another variable cannot appear on the %s clause"_err_en_US,
-            parser::ToUpperCaseLetters(getClauseName(clauseId).str()));
+    if (auto *dataRef{std::get_if<parser::DataRef>(&designator.u)}) {
+      if (!IsDataRefTypeParamInquiry(dataRef)) {
+        if (auto *comp{parser::Unwrap<parser::StructureComponent>(*dataRef)}) {
+          context_.Say(comp->component.source,
+              "A variable that is part of another variable cannot appear on the %s clause"_err_en_US,
+              parser::ToUpperCaseLetters(getClauseName(clauseId).str()));
+        }
       }
     }
   }};

flang/test/Semantics/OpenMP/reduction15.f90

@@ -0,0 +1,32 @@
+!RUN: %python %S/../test_errors.py %s %flang_fc1 -fopenmp -fopenmp-version=50
+
+!Ref: [5.0:297:28-29]
+! If a list item is an array section or an array element, its base expression
+! must be a base language identifier.
+
+module m
+  type t
+    integer :: a(10)
+  end type
+
+contains
+
+  subroutine f00
+    type(t) :: x
+  !ERROR: The base expression of an array element or section in REDUCTION clause must be an identifier
+  !$omp do reduction (+ : x%a(2))
+    do i = 1, 10
+    end do
+  !$omp end do
+  end subroutine
+
+  subroutine f01
+    type(t) :: x
+  !ERROR: The base expression of an array element or section in REDUCTION clause must be an identifier
+  !$omp do reduction (+ : x%a(1:10))
+    do i = 1, 10
+    end do
+  !$omp end do
+  end subroutine
+end
+

flang/test/Semantics/OpenMP/reduction16.f90

@@ -0,0 +1,14 @@
+!RUN: %python %S/../test_errors.py %s %flang_fc1 -fopenmp -fopenmp-version=50
+
+!Ref: [5.0:298:19]
+! A type parameter inquiry cannot appear in a reduction clause.
+
+subroutine f00
+  integer :: x
+!ERROR: Type parameter inquiry is not permitted in REDUCTION clause
+!$omp do reduction (+ : x%kind)
+  do i = 1, 10
+  end do
+!$omp end do
+end subroutine
+