address reviewer comments

Signed-off-by: Bangtian Liu <[email protected]>

Author: bangtianliu

mlir/lib/Bindings/Python/DialectLinalg.cpp

@@ -122,7 +122,7 @@ static void populateDialectLinalgSubmodule(nb::module_ m) {
         "Infers convolution dimensions", nb::arg("op"));
 
   m.def(
-      "get_indexing_maps_attr",
+      "get_indexing_maps",
       [](MlirOperation op) -> std::optional<MlirAttribute> {
         MlirAttribute attr = mlirLinalgGetIndexingMapsAttribute(op);
         if (mlirAttributeIsNull(attr))

mlir/test/python/dialects/linalg/utils.py

@@ -182,13 +182,13 @@ def test_get_indexing_maps_attr():
             @func.FuncOp.from_py_func(a_type, b_type, c_type)
             def matmul_func(a, b, c):
                 zero = arith.ConstantOp(value=FloatAttr.get(f32, 0.0), result=f32)
-                assert not linalg.get_indexing_maps_attr(
+                assert not linalg.get_indexing_maps(
                     zero.operation
                 ), "Expected no indexing_maps on non-linalg op"
 
                 init = linalg.fill(zero, outs=[c])
                 fill_op = init.owner
-                fill_maps = linalg.get_indexing_maps_attr(fill_op)
+                fill_maps = linalg.get_indexing_maps(fill_op)
                 assert fill_maps is not None
                 assert len(fill_maps) == 2
 
@@ -200,7 +200,7 @@ def matmul_func(a, b, c):
 
                 result = linalg.matmul(a, b, outs=(init,))
                 matmul_op = result.owner
-                matmul_maps = linalg.get_indexing_maps_attr(matmul_op)
+                matmul_maps = linalg.get_indexing_maps(matmul_op)
                 assert matmul_maps is not None
                 assert len(matmul_maps) == 3