Skip to content

Commit 3ac91a8

Browse files
committed
Actually set link options
1 parent 5ea4d2a commit 3ac91a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

libc/cmake/modules/LLVMLibCTestRules.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ function(create_libc_unittest fq_target_name)
218218

219219
_get_common_test_compile_options(compile_options "${LIBC_UNITTEST_C_TEST}"
220220
"${LIBC_UNITTEST_FLAGS}")
221-
# TODO: Perhaps we should should we have a separate function for link options.
221+
# TODO: Ideally we would have a separate function for link options.
222222
set(link_options ${compile_options})
223223
list(APPEND compile_options ${LIBC_UNITTEST_COMPILE_OPTIONS})
224224

@@ -274,7 +274,7 @@ function(create_libc_unittest fq_target_name)
274274
target_include_directories(${fq_build_target_name} SYSTEM PRIVATE ${LIBC_INCLUDE_DIR})
275275
target_include_directories(${fq_build_target_name} PRIVATE ${LIBC_SOURCE_DIR})
276276
target_compile_options(${fq_build_target_name} PRIVATE ${compile_options})
277-
target_link_options(${fq_build_target_name} PRIVATE ${compile_options})
277+
target_link_options(${fq_build_target_name} PRIVATE ${link_options})
278278

279279
if(NOT LIBC_UNITTEST_CXX_STANDARD)
280280
set(LIBC_UNITTEST_CXX_STANDARD ${CMAKE_CXX_STANDARD})

0 commit comments

Comments
 (0)