Save the checkpoint

Failed Tests (3):
  Clang :: CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp
  Clang :: CXX/temp/temp.constr/temp.constr.normal/p1.cpp
  Clang :: SemaTemplate/concepts-recursive-inst.cpp

Author: zyn0217

clang/lib/Sema/SemaConcept.cpp

@@ -17,6 +17,7 @@
 #include "clang/AST/Decl.h"
 #include "clang/AST/DeclCXX.h"
 #include "clang/AST/DeclTemplate.h"
+#include "clang/AST/DependenceFlags.h"
 #include "clang/AST/Expr.h"
 #include "clang/AST/ExprConcepts.h"
 #include "clang/AST/TemplateBase.h"
@@ -594,6 +595,19 @@ static bool calculateConstraintSatisfaction(
     ConstraintSatisfaction &Satisfaction,
     UnsignedOrNone PackSubstitutionIndex) {
 
+  // If the expression has been calculated, e.g. when we are in a nested
+  // requirement, do not compute it repeatedly.
+  if (auto *Expr = Constraint.getConceptSpecializationExpr();
+      Expr && Expr->getDependence() == ExprDependence::None) {
+    auto &Calculated = Expr->getSatisfaction();
+    Satisfaction.ContainsErrors = Calculated.ContainsErrors;
+    Satisfaction.IsSatisfied = Calculated.IsSatisfied;
+    Satisfaction.Details.insert(Satisfaction.Details.end(),
+                                Calculated.records().begin(),
+                                Calculated.records().end());
+    return !Satisfaction.ContainsErrors;
+  }
+
   Sema::ContextRAII CurContext(
       S, Constraint.getConceptId()->getNamedConcept()->getDeclContext(),
       /*NewThisContext=*/false);
@@ -1581,6 +1595,8 @@ substituteParameterMappings(Sema &S, NormalizedConstraintWithParamMapping &N,
       SourceLocation Loc = ArgsAsWritten->NumTemplateArgs > I
                                ? ArgsAsWritten->arguments()[I].getLocation()
                                : SourceLocation();
+      // FIXME: Investigate when we couldn't preserve the SourceLoc. What shall we do??
+      // assert(Loc.isValid());
       if (OccurringIndices[I]) {
         NamedDecl *Param = TemplateParams->begin()[I];
         new (&(TempArgs)[J])
@@ -1637,6 +1653,7 @@ substituteParameterMappings(Sema &S, NormalizedConstraintWithParamMapping &N,
     // If this is an empty pack, we have no corresponding SubstArgs.
     if (I < SubstArgs.size())
       Loc = SubstArgs.arguments()[I].getLocation();
+    // assert(Loc.isValid());
     TempArgs[I] = S.getTrivialTemplateArgumentLoc(CTAI.SugaredConverted[I],
                                                   QualType(), Loc);
   }
@@ -1671,9 +1688,29 @@ substituteParameterMappings(Sema &S, ConceptIdConstraint &N,
     assert(CSE);
     TemplateArgumentListInfo Out;
     assert(!N.getBeginLoc().isInvalid());
-    if (S.SubstTemplateArgumentsInParameterMapping(
-            CSE->getTemplateArgsAsWritten()->arguments(), N.getBeginLoc(),
-            MLTAL, Out))
+    // TransformTemplateArguments is unable to preserve the source location of a
+    // pack. The SourceLocation is necessary for the instantiation location.
+    // FIXME: The BaseLoc will be used as the location of the pack expansion,
+    // which is wrong.
+    ArgsAsWritten = CSE->getTemplateArgsAsWritten();
+    SourceLocation InstLocBegin =
+        ArgsAsWritten->arguments().empty()
+            ? ArgsAsWritten->getLAngleLoc()
+            : ArgsAsWritten->arguments().front().getSourceRange().getBegin();
+    SourceLocation InstLocEnd =
+        ArgsAsWritten->arguments().empty()
+            ? ArgsAsWritten->getRAngleLoc()
+            : ArgsAsWritten->arguments().front().getSourceRange().getEnd();
+    Sema::InstantiatingTemplate Inst(
+        S, InstLocBegin,
+        Sema::InstantiatingTemplate::ParameterMappingSubstitution{},
+        const_cast<NamedDecl *>(N.getConstraintDecl()),
+        {InstLocBegin, InstLocEnd});
+    if (Inst.isInvalid())
+      return true;
+
+    if (S.SubstTemplateArgumentsInParameterMapping(ArgsAsWritten->arguments(),
+                                                   N.getBeginLoc(), MLTAL, Out))
       return true;
     Sema::CheckTemplateArgumentInfo CTAI;
     if (S.CheckTemplateArgumentList(CSE->getNamedConcept(),

clang/lib/Sema/TreeTransform.h

@@ -3714,10 +3714,6 @@ class TreeTransform {
                                         ParentContext);
   }
 
-  /// Build a new Objective-C boxed expression.
-  ///
-  /// By default, performs semantic analysis to build the new expression.
-  /// Subclasses may override this routine to provide different behavior.
   ExprResult RebuildConceptSpecializationExpr(NestedNameSpecifierLoc NNS,
       SourceLocation TemplateKWLoc, DeclarationNameInfo ConceptNameInfo,
       NamedDecl *FoundDecl, ConceptDecl *NamedConcept,