Skip to content

Commit 3bb9426

Browse files
committed
address comment
1 parent 18c8ba8 commit 3bb9426

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9015,9 +9015,11 @@ static void checkAddrSpaceIsValidForLibcall(const TargetLowering *TLI,
90159015
static bool isInTailCallPositionWrapper(const CallInst *CI,
90169016
const SelectionDAG *SelDAG,
90179017
bool AllowReturnsFirstArg) {
9018-
9019-
return CI && CI->isTailCall() &&
9020-
isInTailCallPosition(*CI, SelDAG->getTarget(),
9018+
if (!CI || !CI->isTailCall())
9019+
return false;
9020+
// TODO: Fix "returns-first-arg" determination so it doesn't depend on which
9021+
// helper symbol we lower to.
9022+
return isInTailCallPosition(*CI, SelDAG->getTarget(),
90219023
AllowReturnsFirstArg &&
90229024
funcReturnsFirstArgOfCall(*CI));
90239025
}

0 commit comments

Comments
 (0)