Addressed review comments

Author: HemangGadhavi

lldb/source/Host/aix/Host.cpp

@@ -93,7 +93,9 @@ static bool GetExePathAndIds(::pid_t pid, ProcessInstanceInfo &process_info) {
     return false;
 
   std::memcpy(&psinfoData, PsinfoBuffer->getBufferStart(), sizeof(psinfoData));
-  llvm::StringRef PathRef(&(psinfoData.pr_psargs[0]));
+  llvm::StringRef PathRef(
+      psinfoData.pr_psargs,
+      strnlen(psinfoData.pr_psargs, sizeof(psinfoData.pr_psargs)));
   if (PathRef.empty())
     return false;
 
@@ -118,6 +120,8 @@ static bool GetProcessAndStatInfo(::pid_t pid,
   process_info.Clear();
   process_info.SetProcessID(pid);
 
+  if (pid == LLDB_INVALID_PROCESS_ID)
+    return false;
   // Get Executable path/Arch and Get User and Group IDs.
   if (!GetExePathAndIds(pid, process_info))
     return false;

lldb/unittests/Host/CMakeLists.txt

@@ -15,7 +15,7 @@ set (FILES
   XMLTest.cpp
 )
 
-if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android|AIX")
+if (UNIX)
   list(APPEND FILES
     posix/HostTest.cpp
     posix/SupportTest.cpp

lldb/unittests/Host/posix/HostTest.cpp

@@ -40,9 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
        triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
 
   ProcessInstanceInfo Info;
-#ifndef _AIX
-  ASSERT_FALSE(Host::GetProcessInfo(0, Info));
-#endif /* ifndef _AIX */
+
+  ASSERT_FALSE(Host::GetProcessInfo(LLDB_INVALID_PROCESS_ID, Info));
+
   ASSERT_TRUE(Host::GetProcessInfo(getpid(), Info));
 
   ASSERT_TRUE(Info.ProcessIDIsValid());

lldb/unittests/Host/posix/SupportTest.cpp

@@ -6,25 +6,16 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "lldb/Host/linux/Support.h"
 #include "lldb/Host/posix/Support.h"
 #include "llvm/Support/Threading.h"
 #include "gtest/gtest.h"
 
 using namespace lldb_private;
 
+#ifndef __APPLE__
 TEST(Support, getProcFile_Pid) {
   auto BufferOrError = getProcFile(getpid(), "status");
   ASSERT_TRUE(BufferOrError);
   ASSERT_TRUE(*BufferOrError);
 }
-
-#ifndef _AIX
-#ifdef LLVM_ENABLE_THREADING
-TEST(Support, getProcFile_Tid) {
-  auto BufferOrError = getProcFile(getpid(), llvm::get_threadid(), "comm");
-  ASSERT_TRUE(BufferOrError);
-  ASSERT_TRUE(*BufferOrError);
-}
-#endif /*ifdef LLVM_ENABLE_THREADING */
-#endif /*ifndef _AIX */
+#endif // #ifndef __APPLE__

lldb/unittests/Process/Linux/ProcfsTests.cpp

@@ -8,6 +8,7 @@
 
 #include "Procfs.h"
 
+#include "lldb/Host/linux/Support.h"
 #include "lldb/Host/posix/Support.h"
 
 #include "gmock/gmock.h"
@@ -118,3 +119,11 @@ TEST(Perf, RealPtraceScope) {
   ASSERT_LE(*ptrace_scope, 3)
       << "Sensible values of ptrace_scope are between 0 and 3";
 }
+
+#ifdef LLVM_ENABLE_THREADING
+TEST(Support, getProcFile_Tid) {
+  auto BufferOrError = getProcFile(getpid(), llvm::get_threadid(), "comm");
+  ASSERT_TRUE(BufferOrError);
+  ASSERT_TRUE(*BufferOrError);
+}
+#endif /*ifdef LLVM_ENABLE_THREADING */