Skip to content

Commit 3c09391

Browse files
ashgtiJDevlieghere
andauthored
Apply suggestions from code review
Co-authored-by: Jonas Devlieghere <[email protected]>
1 parent e883eec commit 3c09391

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lldb/tools/lldb-dap/Handler/LaunchRequestHandler.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const {
2626
dap.stop_at_entry = arguments.stopOnEntry;
2727

2828
if (!arguments.launchCommands.empty() && arguments.runInTerminal) {
29-
return make_error<DAPError>("launchCommands and runInTerminal cannot "
30-
"both be set, use one or the other.");
29+
return make_error<DAPError>("launchCommands and runInTerminal are mutually exclusive");
3130
}
3231

3332
PrintWelcomeMessage();

lldb/tools/lldb-dap/Handler/RestartRequestHandler.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ void RestartRequestHandler::operator()(
9090
if (arguments) {
9191
// The optional `arguments` field in RestartRequest can contain an updated
9292
// version of the launch arguments. If there's one, use it.
93-
const llvm::json::Value *restart_arguments = arguments->get("arguments");
94-
if (restart_arguments) {
93+
if (const llvm::json::Value *restart_arguments = arguments->get("arguments")) {
9594
protocol::LaunchRequestArguments updated_arguments;
9695
llvm::json::Path::Root root;
9796
if (!fromJSON(*restart_arguments, updated_arguments, root)) {

0 commit comments

Comments
 (0)