[llvm][AArch64] Add missing default cases (#89930)

Troy-Butler · web-flow · commit 3c2e614acd76 · 2024-04-24T11:04:28.000-07:00
Addresses issue #89709. Functions getAUTOpcodeForKey() and getPACOpcodeForKey() contain switch statements without default cases. Resolved by adding a call to llvm_unreachable() at the end of each function. --------- Signed-off-by: Troy-Butler <squintik@outlook.com> Co-authored-by: Troy-Butler <squintik@outlook.com>
diff --git a/llvm/lib/Target/AArch64/AArch64InstrInfo.h b/llvm/lib/Target/AArch64/AArch64InstrInfo.h
@@ -725,6 +725,7 @@ static inline unsigned getAUTOpcodeForKey(AArch64PACKey::ID K, bool Zero) {
   case DA: return Zero ? AArch64::AUTDZA : AArch64::AUTDA;
   case DB: return Zero ? AArch64::AUTDZB : AArch64::AUTDB;
   }
+  llvm_unreachable("Unhandled AArch64PACKey::ID enum");
 }
 
 /// Return PAC opcode to be used for a ptrauth sign using the given key, or its
@@ -737,6 +738,7 @@ static inline unsigned getPACOpcodeForKey(AArch64PACKey::ID K, bool Zero) {
   case DA: return Zero ? AArch64::PACDZA : AArch64::PACDA;
   case DB: return Zero ? AArch64::PACDZB : AArch64::PACDB;
   }
+  llvm_unreachable("Unhandled AArch64PACKey::ID enum");
 }
 
 // struct TSFlags {

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,7 @@ static inline unsigned getAUTOpcodeForKey(AArch64PACKey::ID K, bool Zero) {`
`725`	`725`	`case DA: return Zero ? AArch64::AUTDZA : AArch64::AUTDA;`
`726`	`726`	`case DB: return Zero ? AArch64::AUTDZB : AArch64::AUTDB;`
`727`	`727`	`}`
	`728`	`+ llvm_unreachable("Unhandled AArch64PACKey::ID enum");`
`728`	`729`	`}`
`729`	`730`
`730`	`731`	`/// Return PAC opcode to be used for a ptrauth sign using the given key, or its`
`@@ -737,6 +738,7 @@ static inline unsigned getPACOpcodeForKey(AArch64PACKey::ID K, bool Zero) {`
`737`	`738`	`case DA: return Zero ? AArch64::PACDZA : AArch64::PACDA;`
`738`	`739`	`case DB: return Zero ? AArch64::PACDZB : AArch64::PACDB;`
`739`	`740`	`}`
	`741`	`+ llvm_unreachable("Unhandled AArch64PACKey::ID enum");`
`740`	`742`	`}`
`741`	`743`
`742`	`744`	`// struct TSFlags {`