Skip to content

Commit 3cee7d1

Browse files
committed
Add comment about possible further improvement
1 parent 13736a6 commit 3cee7d1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===- MemorySanitizer.cpp - detector of uninitialized reads --------------===//
1+
.//===- MemorySanitizer.cpp - detector of uninitialized reads --------------===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
@@ -3285,9 +3285,11 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
32853285
// e.g., if 0/1 are initialized bits with concrete value 0/1, and ? is an
32863286
// uninitialized bit:
32873287
// - 0001 0??? is fully initialized
3288-
// - 000? ???? is fully uninitialized
3288+
// - 000? ???? is fully uninitialized (*)
32893289
// - ???? ???? is fully uninitialized
32903290
// - 0000 0000 is fully initialized iff !is_zero_poison
3291+
// (*) TODO: arguably, since the number of zeros is in the range [0, 8], we
3292+
// only need to poison 4 bits.
32913293
//
32923294
// OutputShadow =
32933295
// ((ConcreteZerosCount >= ShadowZerosCount) && !AllZeroShadow)

0 commit comments

Comments
 (0)