Skip to content

Commit 3d03793

Browse files
author
George Hu
committed
Address PR comments
1 parent 467a8ed commit 3d03793

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lldb/source/Plugins/SymbolLocator/Debuginfod/SymbolLocatorDebuginfod.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,8 @@ static llvm::StringRef getFileName(const ModuleSpec &module_spec,
146146
std::string url_path) {
147147
// Check if the URL path requests an executable file or a symbol file
148148
bool is_executable = url_path.find("debuginfo") == std::string::npos;
149-
if (is_executable) {
149+
if (is_executable)
150150
return module_spec.GetFileSpec().GetFilename().GetStringRef();
151-
}
152151
llvm::StringRef symbol_file =
153152
module_spec.GetSymbolFileSpec().GetFilename().GetStringRef();
154153
// Remove llvmcache- prefix and hash, keep origin file name
@@ -191,9 +190,8 @@ GetFileForModule(const ModuleSpec &module_spec,
191190
std::string url_path = UrlBuilder(build_id);
192191
llvm::StringRef file_name = getFileName(module_spec, url_path);
193192
std::string cache_file_name = llvm::toHex(build_id, true);
194-
if (!file_name.empty()) {
193+
if (!file_name.empty())
195194
cache_file_name += "-" + file_name.str();
196-
}
197195
llvm::Expected<std::string> result = llvm::getCachedOrDownloadArtifact(
198196
cache_file_name, url_path, cache_path, debuginfod_urls, timeout,
199197
pruning_policy);

0 commit comments

Comments
 (0)