[InstCombine] Address review comments. NFC.

dtcxzyw · dtcxzyw · commit 3d4f9bf50414 · 2025-02-06T23:55:09.000+08:00
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
@@ -612,8 +612,8 @@ static Value *foldLogOpOfMaskedICmps(Value *LHS, Value *RHS, bool IsAnd,
         return LHS;
       if (NewMask == *ConstD) {
         if (IsLogical) {
-          if (auto *ICmp = dyn_cast<ICmpInst>(RHS))
-            ICmp->setSameSign(false);
+          if (auto *RHSI = dyn_cast<Instruction>(RHS))
+            RHSI->dropPoisonGeneratingFlags();
         }
         return RHS;
       }

Original file line number	Diff line number	Diff line change
`@@ -612,8 +612,8 @@ static Value foldLogOpOfMaskedICmps(Value LHS, Value *RHS, bool IsAnd,`
`612`	`612`	`return LHS;`
`613`	`613`	`if (NewMask == *ConstD) {`
`614`	`614`	`if (IsLogical) {`
`615`		`- if (auto *ICmp = dyn_cast<ICmpInst>(RHS))`
`616`		`- ICmp->setSameSign(false);`
	`615`	`+ if (auto *RHSI = dyn_cast<Instruction>(RHS))`
	`616`	`+ RHSI->dropPoisonGeneratingFlags();`
`617`	`617`	`}`
`618`	`618`	`return RHS;`
`619`	`619`	`}`