Address feedback and fix the CI

Author: var-const

libcxx/docs/Hardening.rst

@@ -74,7 +74,8 @@ to control the level by passing **one** of the following options to the compiler
    pre-built components. Most libc++ code is header-based, so a user-provided
    value for ``_LIBCPP_HARDENING_MODE`` will be mostly respected.
 
-In some cases, users might want to override the default assertion semantic.
+In some cases, users might want to override the assertion semantic used by the
+library.
 This can be done similarly to setting the hardening mode; please refer to the
 :ref:`relevant section <assertion-semantics>`.
 

libcxx/test/libcxx/assertions/log_hardening_failure.pass.cpp

@@ -13,7 +13,9 @@
 
 #include <__log_hardening_failure>
 
-static_assert(noexcept(std::__log_hardening_failure("")));
+#include "test_macros.h"
+
+ASSERT_NOEXCEPT(std::__log_hardening_failure(""));
 
 int main(int, char**) {
   std::__log_hardening_failure("Some message");

libcxx/test/support/check_assertion.h

@@ -487,7 +487,7 @@ bool ExpectLog(const char* stmt, Func&& func) {
 #define TEST_LIBCPP_ASSERT_FAILURE(expr, message) \
     assert(( ExpectLog(#expr, [&]() { (void)(expr); }) ))
 #else
-#error "_LIBCPP_ASSERTION_SEMANTIC is set to an invalid value"
+#error "Unknown value for _LIBCPP_ASSERTION_SEMANTIC"
 #endif // _LIBCPP_ASSERTION_SEMANTIC == _LIBCPP_ASSERTION_SEMANTIC_ENFORCE
 
 #else