Apply feedback

Author: monthdev

clang/lib/AST/ByteCode/InterpBuiltin.cpp

@@ -2826,10 +2826,9 @@ static bool interp__builtin_ia32_test_op(
   assert(LHS.getNumElems() == RHS.getNumElems());
 
   unsigned SourceLen = LHS.getNumElems();
-  const QualType ElemQT = getElemType(LHS);
-  const OptPrimType ElemPT = S.getContext().classify(ElemQT);
+  QualType ElemQT = getElemType(LHS);
+  OptPrimType ElemPT = S.getContext().classify(ElemQT);
   unsigned LaneWidth = S.getASTContext().getTypeSize(ElemQT);
-  APInt SignMask = APInt::getSignMask(LaneWidth);
 
   APInt AWide(LaneWidth * SourceLen, 0);
   APInt BWide(LaneWidth * SourceLen, 0);
@@ -2838,16 +2837,16 @@ static bool interp__builtin_ia32_test_op(
     APInt ALane;
     APInt BLane;
 
-    if (ElemQT->isIntegerType()) { // Get value
+    if (ElemQT->isIntegerType()) { // Get value.
       INT_TYPE_SWITCH_NO_BOOL(*ElemPT, {
         ALane = LHS.elem<T>(I).toAPSInt();
         BLane = RHS.elem<T>(I).toAPSInt();
       });
-    } else if (ElemQT->isFloatingType()) { // Get only sign bit
+    } else if (ElemQT->isFloatingType()) { // Get only sign bit.
       using T = PrimConv<PT_Float>::T;
-      ALane = LHS.elem<T>(I).getAPFloat().bitcastToAPInt() & SignMask;
-      BLane = RHS.elem<T>(I).getAPFloat().bitcastToAPInt() & SignMask;
-    } else { // Must be integer or floating type
+      ALane = LHS.elem<T>(I).getAPFloat().bitcastToAPInt().isNegative();
+      BLane = RHS.elem<T>(I).getAPFloat().bitcastToAPInt().isNegative();
+    } else { // Must be integer or floating type.
       return false;
     }
     AWide.insertBits(ALane, I * LaneWidth);

clang/lib/AST/ExprConstant.cpp

@@ -13775,26 +13775,28 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
 
         unsigned SourceLen = SourceLHS.getVectorLength();
         const VectorType *VT = E->getArg(0)->getType()->castAs<VectorType>();
-        const QualType ElemQT = VT->getElementType();
+        QualType ElemQT = VT->getElementType();
         unsigned LaneWidth = Info.Ctx.getTypeSize(ElemQT);
-        APInt SignMask = APInt::getSignMask(LaneWidth);
 
         APInt AWide(LaneWidth * SourceLen, 0);
         APInt BWide(LaneWidth * SourceLen, 0);
 
         for (unsigned I = 0; I != SourceLen; ++I) {
           APInt ALane;
           APInt BLane;
-
-          if (ElemQT->isIntegerType()) { // Get value
+          if (ElemQT->isIntegerType()) { // Get value.
             ALane = SourceLHS.getVectorElt(I).getInt();
             BLane = SourceRHS.getVectorElt(I).getInt();
-          } else if (ElemQT->isFloatingType()) { // Get only sign bit
-            ALane = SourceLHS.getVectorElt(I).getFloat().bitcastToAPInt() &
-                    SignMask;
-            BLane = SourceRHS.getVectorElt(I).getFloat().bitcastToAPInt() &
-                    SignMask;
-          } else { // Must be integer or floating type
+          } else if (ElemQT->isFloatingType()) { // Get only sign bit.
+            ALane = SourceLHS.getVectorElt(I)
+                        .getFloat()
+                        .bitcastToAPInt()
+                        .isNegative();
+            BLane = SourceRHS.getVectorElt(I)
+                        .getFloat()
+                        .bitcastToAPInt()
+                        .isNegative();
+          } else { // Must be integer or floating type.
             return false;
           }
           AWide.insertBits(ALane, I * LaneWidth);