switch to generic error message

Author: charles-zablit

lldb/include/lldb/DataFormatters/TypeSynthetic.h

@@ -118,10 +118,7 @@ class SyntheticValueProviderFrontEnd : public SyntheticChildrenFrontEnd {
   lldb::ValueObjectSP GetChildAtIndex(uint32_t idx) override { return nullptr; }
 
   llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
-    return llvm::createStringError(
-        "'SyntheticChildrenFrontEnd::SyntheticValueProviderFrontEnd' cannot "
-        "find index of child '%s'",
-        name.AsCString());
+    return llvm::createStringError("Type has no child named '%s'", name.AsCString());
   }
 
   lldb::ChildCacheState Update() override {

lldb/include/lldb/Interpreter/ScriptInterpreter.h

@@ -371,9 +371,7 @@ class ScriptInterpreter : public PluginInterface {
   virtual llvm::Expected<int>
   GetIndexOfChildWithName(const StructuredData::ObjectSP &implementor,
                           const char *child_name) {
-    return llvm::createStringError(
-        "'PluginInterface::ScriptInterpreter' cannot find index of child '%s'",
-        child_name);
+    return llvm::createStringError("Type has no child named '%s'", child_name);
   }
 
   virtual bool

lldb/source/DataFormatters/TypeSynthetic.cpp

@@ -67,9 +67,7 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString name) {
       }
     }
   }
-  return llvm::createStringError(
-      "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
-      name.AsCString());
+  return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 }
 
 std::string TypeFilterImpl::GetDescription() {
@@ -223,9 +221,7 @@ bool ScriptedSyntheticChildren::FrontEnd::MightHaveChildren() {
 llvm::Expected<size_t>
 ScriptedSyntheticChildren::FrontEnd::GetIndexOfChildWithName(ConstString name) {
   if (!m_wrapper_sp || m_interpreter == nullptr)
-    return llvm::createStringError(
-        "'ScriptedSyntheticChildren::FrontEnd' cannot find index of child '%s'",
-        name.AsCString());
+    return llvm::createStringError("Type has no child named '%s'", name.AsCString());
   return m_interpreter->GetIndexOfChildWithName(m_wrapper_sp,
                                                 name.GetCString());
 }

lldb/source/DataFormatters/VectorType.cpp

@@ -274,10 +274,7 @@ class VectorTypeSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
     uint32_t idx = ExtractIndexFromString(item_name);
     if (idx == UINT32_MAX ||
         (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors()))
-      return llvm::createStringError(
-          "'SyntheticChildrenFrontEnd::VectorTypeSyntheticFrontEnd' cannot "
-          "find index of child '%s'. (idx='" PRIu32 "')",
-          name.AsCString(), idx);
+      return llvm::createStringError("Type has no child named '%s'", name.AsCString());
     return idx;
   }
 

lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp

@@ -146,9 +146,7 @@ class BlockPointerSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
 
   llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
     if (!m_block_struct_type.IsValid())
-      return llvm::createStringError("'BlockPointerSyntheticFrontEnd' cannot "
-                                     "find index of child '%s'",
-                                     name.AsCString());
+      return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 
     const bool omit_empty_base_classes = false;
     return m_block_struct_type.GetIndexOfChildWithName(name.AsCString(),

lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp

@@ -203,11 +203,7 @@ llvm::Expected<size_t>
 StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
     ConstString name) {
   if (!m_resume_ptr_sp || !m_destroy_ptr_sp)
-    return llvm::createStringError(
-        "'StdlibCoroutineHandleSyntheticFrontEnd' "
-        "cannot find index of child '%s'. (m_resume_ptr_sp='%p', "
-        "m_destroy_ptr_sp='%p')",
-        name.AsCString(), m_resume_ptr_sp.get(), m_destroy_ptr_sp.get());
+    return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 
   if (name == ConstString("resume"))
     return 0;
@@ -216,9 +212,7 @@ StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
   if (name == ConstString("promise_ptr") && m_promise_ptr_sp)
     return 2;
 
-  return llvm::createStringError("'StdlibCoroutineHandleSyntheticFrontEnd' "
-                                 "cannot find index of child '%s'",
-                                 name.AsCString());
+  return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 }
 
 SyntheticChildrenFrontEnd *

lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp

@@ -30,11 +30,8 @@ class GenericBitsetFrontEnd : public SyntheticChildrenFrontEnd {
 
   llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
     size_t idx = formatters::ExtractIndexFromString(name.GetCString());
-    if (idx == UINT32_MAX) {
-      return llvm::createStringError("'GenericBitsetFrontEnd' cannot find "
-                                     "index of child '%s'",
-                                     name.AsCString());
-    }
+    if (idx == UINT32_MAX)
+      return llvm::createStringError("Type has no child named '%s'", name.AsCString());
     return idx;
   }
 

lldb/source/Plugins/Language/CPlusPlus/GenericOptional.cpp

@@ -40,11 +40,8 @@ class GenericOptionalFrontend : public SyntheticChildrenFrontEnd {
     if (name == "$$dereference$$")
       return 0;
     size_t idx = formatters::ExtractIndexFromString(name.GetCString());
-    if (idx == UINT32_MAX) {
-      return llvm::createStringError("'GenericOptionalFrontend' cannot find "
-                                     "index of child '%s'",
-                                     name.AsCString());
-    }
+    if (idx == UINT32_MAX)
+      return llvm::createStringError("Type has no child named '%s'", name.AsCString());
     return idx;
   }
 

lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp

@@ -316,9 +316,7 @@ lldb_private::formatters::LibcxxSharedPtrSyntheticFrontEnd::
     return 0;
   if (name == "$$dereference$$")
     return 1;
-  return llvm::createStringError("'LibcxxSharedPtrSyntheticFrontEnd' cannot "
-                                 "find index of child '%s'",
-                                 name.AsCString());
+  return llvm::createStringError("Type has no child named '%s'",name.AsCString());
 }
 
 lldb_private::formatters::LibcxxSharedPtrSyntheticFrontEnd::
@@ -419,10 +417,7 @@ lldb_private::formatters::LibcxxUniquePtrSyntheticFrontEnd::
     return 1;
   if (name == "$$dereference$$")
     return 2;
-  return llvm::createStringError(
-      "'ScriptedSyntheticChildren::LibcxxUniquePtrSyntheticFrontEnd' cannot "
-      "find index of child '%s'",
-      name.AsCString());
+  return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 }
 
 bool lldb_private::formatters::LibcxxContainerSummaryProvider(

lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp

@@ -135,9 +135,7 @@ lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::
     GetIndexOfChildWithName(ConstString name) {
   if (name == "Value")
     return 0;
-  return llvm::createStringError("'LibcxxStdAtomicSyntheticFrontEnd' cannot "
-                                 "find index of child '%s'",
-                                 name.AsCString());
+  return llvm::createStringError("Type has no child named '%s'", name.AsCString());
 }
 
 SyntheticChildrenFrontEnd *