Silence "non-void function does not return a value in all control paths" in Release builds. NFC

d0k · d0k · commit 3dc9f2da29f7 · 2025-06-23T17:58:41.000+02:00
diff --git a/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp b/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp
@@ -541,7 +541,7 @@ static mpi::MPI_ReductionOpEnumAttr getMPIReductionOp(ReductionKindAttr kind) {
   case ReductionKind::BitwiseXor:
     return getReductionOp(mpi::MPI_ReductionOpEnum::MPI_BXOR);
   default:
-    assert(false && "Unknown/unsupported reduction kind");
+    llvm_unreachable("Unknown/unsupported reduction kind");
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@ static mpi::MPI_ReductionOpEnumAttr getMPIReductionOp(ReductionKindAttr kind) {`
`541`	`541`	`case ReductionKind::BitwiseXor:`
`542`	`542`	`return getReductionOp(mpi::MPI_ReductionOpEnum::MPI_BXOR);`
`543`	`543`	`default:`
`544`		`- assert(false && "Unknown/unsupported reduction kind");`
	`544`	`+ llvm_unreachable("Unknown/unsupported reduction kind");`
`545`	`545`	`}`
`546`	`546`	`}`
`547`	`547`