address comments

Author: charles-zablit

lldb/include/lldb/Target/StackFrame.h

@@ -354,7 +354,7 @@ class StackFrame : public ExecutionContextScope,
   /// \param [in] frame_marker
   ///   Optional string that will be prepended to the frame output description.
   void DumpUsingSettingsFormat(Stream *strm, bool show_unique = false,
-                               const std::string &frame_marker = "");
+                               llvm::StringRef frame_marker = "");
 
   /// Print a description for this frame using a default format.
   ///
@@ -390,8 +390,7 @@ class StackFrame : public ExecutionContextScope,
   /// \return
   ///   Returns true if successful.
   bool GetStatus(Stream &strm, bool show_frame_info, bool show_source,
-                 bool show_unique = false,
-                 const std::string &frame_marker = "");
+                 bool show_unique = false, llvm::StringRef frame_marker = "");
 
   /// Query whether this frame is a concrete frame on the call stack, or if it
   /// is an inlined frame derived from the debug information and presented by

lldb/source/Target/StackFrame.cpp

@@ -1935,7 +1935,7 @@ bool StackFrame::DumpUsingFormat(Stream &strm,
 }
 
 void StackFrame::DumpUsingSettingsFormat(Stream *strm, bool show_unique,
-                                         const std::string &frame_marker) {
+                                         llvm::StringRef frame_marker) {
   if (strm == nullptr)
     return;
 
@@ -2035,7 +2035,7 @@ bool StackFrame::HasCachedData() const {
 }
 
 bool StackFrame::GetStatus(Stream &strm, bool show_frame_info, bool show_source,
-                           bool show_unique, const std::string &frame_marker) {
+                           bool show_unique, llvm::StringRef frame_marker) {
   if (show_frame_info) {
     strm.Indent();
     DumpUsingSettingsFormat(&strm, show_unique, frame_marker);

lldb/source/Target/StackFrameList.cpp

@@ -900,15 +900,14 @@ bool StackFrameList::IsPreviousFrameHidden(lldb_private::StackFrame &frame) {
 
 std::wstring StackFrameList::FrameMarker(lldb::StackFrameSP frame_sp,
                                          lldb::StackFrameSP selected_frame_sp) {
-  if (frame_sp == selected_frame_sp) {
+  if (frame_sp == selected_frame_sp)
     return Terminal::SupportsUnicode() ? L" * " : L"* ";
-  } else if (!Terminal::SupportsUnicode()) {
+  else if (!Terminal::SupportsUnicode())
     return L"  ";
-  } else if (IsPreviousFrameHidden(*frame_sp)) {
+  else if (IsPreviousFrameHidden(*frame_sp))
     return L" ﹉";
-  } else if (IsNextFrameHidden(*frame_sp)) {
+  else if (IsNextFrameHidden(*frame_sp))
     return L" ﹍";
-  }
   return L" 　";
 }