Skip to content

Commit 3f797a8

Browse files
authored
[mlir][spirv] Add missing #include in SPIRVImageInterfaces.h (#153727)
SPIRVImageInterfaces.h.inc uses some types, e.g. mlir::TypedValue, without #include the necessary headers. This is fine most of the time, but we did run into a weird case where bazel fails to compile //mlir:SPIRVImageInterfaces on clang19 for ChromiumOS when parse_headers (see [1]) is specified. [1]: https://bazel.build/docs/bazel-and-cpp#toolchain-features
1 parent a1b6e7f commit 3f797a8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
#ifndef MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_
1010
#define MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_
1111

12+
#include "mlir/IR/OpDefinition.h"
13+
1214
#include "mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h.inc"
1315

1416
#endif // MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_

0 commit comments

Comments
 (0)