Skip to content

Commit 3f7b885

Browse files
authored
[IVDesc] Drop unused arg in isConditionalRdxPattern (NFC) (#142942)
1 parent f482b96 commit 3f7b885

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

llvm/include/llvm/Analysis/IVDescriptors.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,7 @@ class RecurrenceDescriptor {
172172

173173
/// Returns a struct describing if the instruction is a
174174
/// Select(FCmp(X, Y), (Z = X op PHINode), PHINode) instruction pattern.
175-
LLVM_ABI static InstDesc isConditionalRdxPattern(RecurKind Kind,
176-
Instruction *I);
175+
LLVM_ABI static InstDesc isConditionalRdxPattern(Instruction *I);
177176

178177
/// Returns the opcode corresponding to the RecurrenceKind.
179178
LLVM_ABI static unsigned getOpcode(RecurKind Kind);

llvm/lib/Analysis/IVDescriptors.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ bool RecurrenceDescriptor::AddReductionVar(
483483
} else if (!isa<PHINode>(UI) &&
484484
((!isa<FCmpInst>(UI) && !isa<ICmpInst>(UI) &&
485485
!isa<SelectInst>(UI)) ||
486-
(!isConditionalRdxPattern(Kind, UI).isRecurrence() &&
486+
(!isConditionalRdxPattern(UI).isRecurrence() &&
487487
!isAnyOfPattern(TheLoop, Phi, UI, IgnoredVal)
488488
.isRecurrence() &&
489489
!isMinMaxPattern(UI, Kind, IgnoredVal).isRecurrence())))
@@ -802,7 +802,7 @@ RecurrenceDescriptor::isMinMaxPattern(Instruction *I, RecurKind Kind,
802802
/// %add = fadd %0, %sum.1
803803
/// %sum.2 = select %cmp, %add, %sum.1
804804
RecurrenceDescriptor::InstDesc
805-
RecurrenceDescriptor::isConditionalRdxPattern(RecurKind Kind, Instruction *I) {
805+
RecurrenceDescriptor::isConditionalRdxPattern(Instruction *I) {
806806
SelectInst *SI = dyn_cast<SelectInst>(I);
807807
if (!SI)
808808
return InstDesc(false, I);
@@ -874,7 +874,7 @@ RecurrenceDescriptor::InstDesc RecurrenceDescriptor::isRecurrenceInstr(
874874
case Instruction::Select:
875875
if (Kind == RecurKind::FAdd || Kind == RecurKind::FMul ||
876876
Kind == RecurKind::Add || Kind == RecurKind::Mul)
877-
return isConditionalRdxPattern(Kind, I);
877+
return isConditionalRdxPattern(I);
878878
if (isFindLastIVRecurrenceKind(Kind) && SE)
879879
return isFindLastIVPattern(L, OrigPhi, I, *SE);
880880
[[fallthrough]];

0 commit comments

Comments
 (0)