Factor out pcrelOffset call

Author: int3

lld/MachO/Arch/X86_64.cpp

@@ -65,7 +65,7 @@ static constexpr std::array<RelocAttrs, 10> relocAttrsArray{{
 #undef B
 }};
 
-static int pcrelOffset(uint8_t type) {
+static int getPcrelOffset(uint8_t type) {
   switch (type) {
   case X86_64_RELOC_SIGNED_1:
     return 1;
@@ -82,14 +82,15 @@ int64_t X86_64::getEmbeddedAddend(MemoryBufferRef mb, uint64_t offset,
                                   relocation_info rel) const {
   auto *buf = reinterpret_cast<const uint8_t *>(mb.getBufferStart());
   const uint8_t *loc = buf + offset + rel.r_address;
+  int pcrelOffset = getPcrelOffset(rel.r_type);
 
   switch (rel.r_length) {
   case 0:
-    return *loc + pcrelOffset(rel.r_type);
+    return *loc + pcrelOffset;
   case 2:
-    return static_cast<int32_t>(read32le(loc)) + pcrelOffset(rel.r_type);
+    return static_cast<int32_t>(read32le(loc)) + pcrelOffset;
   case 3:
-    return read64le(loc) + pcrelOffset(rel.r_type);
+    return read64le(loc) + pcrelOffset;
   default:
     llvm_unreachable("invalid r_length");
   }
@@ -98,7 +99,7 @@ int64_t X86_64::getEmbeddedAddend(MemoryBufferRef mb, uint64_t offset,
 void X86_64::relocateOne(uint8_t *loc, const Reloc &r, uint64_t value,
                          uint64_t relocVA) const {
   if (r.pcrel) {
-    uint64_t pc = relocVA + (1 << r.length) + pcrelOffset(r.type);
+    uint64_t pc = relocVA + (1 << r.length) + getPcrelOffset(r.type);
     value -= pc;
   }