resolve comments

Author: XChy

llvm/lib/CodeGen/LiveIntervals.cpp

@@ -665,10 +665,10 @@ void LiveIntervals::extendToIndices(LiveRange &LR,
 void LiveIntervals::pruneValue(LiveRange &LR, SlotIndex Kill,
                                SmallVectorImpl<SlotIndex> *EndPoints) {
   LiveQueryResult LRQ = LR.Query(Kill);
-  // LR may have liveness reachable from early clobber killer, which may be
+  // LR may have liveness reachable from early clobber slot, which may be
   // only live-in instead of live-out of the instruction.
   // For example, LR =[1r, 3r), Kill = 3e, we have to prune [3e, 3r) of LR.
-  VNInfo *VNI = Kill.isEarlyClobber() ? LRQ.valueIn() : LRQ.valueOutOrDead();
+  VNInfo *VNI = LRQ.valueOutOrDead() ? LRQ.valueOutOrDead() : LRQ.valueIn();
   if (!VNI)
     return;
 

llvm/test/CodeGen/RISCV/rvv/pr134424.ll

@@ -1,7 +1,7 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
 ; RUN: llc -O1 -mtriple=riscv64 -mattr=+v < %s | FileCheck %s
 
-define i32 @main(i64 %0, i32 %a.promoted49.i, i1 %tobool.not.us.i.4, i1 %tobool.not.us.i.1.4, i1 %tobool.not.us.i.2.4) {
+define i32 @main(i64 %input_value, i32 %base_value, i1 %cond_flag1, i1 %cond_flag2, i1 %cond_flag3) {
 ; CHECK-LABEL: main:
 ; CHECK:       # %bb.0: # %for.body.us.preheader.i
 ; CHECK-NEXT:    andi a3, a3, 1
@@ -58,18 +58,19 @@ define i32 @main(i64 %0, i32 %a.promoted49.i, i1 %tobool.not.us.i.4, i1 %tobool.
 ; CHECK-NEXT:    bge a3, a0, .LBB0_9
 ; CHECK-NEXT:    j .LBB0_10
 for.body.us.preheader.i:
-  %1 = insertelement <4 x i64> zeroinitializer, i64 %0, i64 1
-  %2 = shufflevector <4 x i64> %1, <4 x i64> zeroinitializer, <4 x i32> <i32 0, i32 1, i32 1, i32 1>
-  %3 = icmp sle <4 x i64> %2, zeroinitializer
-  %cond.us.i.4 = select i1 %tobool.not.us.i.4, i32 %a.promoted49.i, i32 1
-  %cond.us.i.1.4 = select i1 %tobool.not.us.i.1.4, i32 %a.promoted49.i, i32 1
-  %cond.us.i.2.4 = select i1 %tobool.not.us.i.2.4, i32 %a.promoted49.i, i32 1
-  %4 = zext <4 x i1> %3 to <4 x i32>
-  %5 = shufflevector <4 x i32> %4, <4 x i32> zeroinitializer, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 poison, i32 poison, i32 poison, i32 poison>
-  %6 = call i32 @llvm.vector.reduce.smin.v8i32(<8 x i32> %5)
-  %7 = call i32 @llvm.smin.i32(i32 %6, i32 %cond.us.i.4)
-  %8 = call i32 @llvm.smin.i32(i32 %cond.us.i.1.4, i32 %cond.us.i.2.4)
-  %9 = call i32 @llvm.smin.i32(i32 %7, i32 %8)
-  store i32 %9, ptr null, align 4
+  %partial_vector = insertelement <4 x i64> zeroinitializer, i64 %input_value, i64 1
+  %comparison_vector = shufflevector <4 x i64> %partial_vector, <4 x i64> zeroinitializer, <4 x i32> <i32 0, i32 1, i32 1, i32 1>
+  %comparison_result = icmp sle <4 x i64> %comparison_vector, zeroinitializer
+  %selected_value1 = select i1 %cond_flag1, i32 %base_value, i32 1
+  %selected_value2 = select i1 %cond_flag2, i32 %base_value, i32 1
+  %selected_value3 = select i1 %cond_flag3, i32 %base_value, i32 1
+  %bool_to_int = zext <4 x i1> %comparison_result to <4 x i32>
+  %extended_vector = shufflevector <4 x i32> %bool_to_int, <4 x i32> zeroinitializer, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 poison, i32 poison, i32 poison, i32 poison>
+  %vector_min = call i32 @llvm.vector.reduce.smin.v8i32(<8 x i32> %extended_vector)
+  %min1 = call i32 @llvm.smin.i32(i32 %vector_min, i32 %selected_value1)
+  %min2 = call i32 @llvm.smin.i32(i32 %selected_value2, i32 %selected_value3)
+  %final_min = call i32 @llvm.smin.i32(i32 %min1, i32 %min2)
+  store i32 %final_min, ptr null, align 4
   ret i32 0
 }
+