Reuse createBinOpShuffle

lukel97 · lukel97 · commit 401ffa6fa4c5 · 2025-04-30T19:05:07.000+08:00
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -2286,13 +2286,9 @@ Instruction *InstCombinerImpl::foldVectorBinop(BinaryOperator &Inst) {
 
       Value *NewLHS = ConstOp1 ? V1 : NewC;
       Value *NewRHS = ConstOp1 ? NewC : V1;
-      Value *XY = Builder.CreateBinOp(Opcode, NewLHS, NewRHS);
-      if (auto *BO = dyn_cast<BinaryOperator>(XY))
-        BO->copyIRFlags(&Inst);
-
       VectorType *VTy = cast<VectorType>(Inst.getType());
-      SmallVector<int> NewM(VTy->getElementCount().getKnownMinValue(), 0);
-      return new ShuffleVectorInst(XY, NewM);
+      SmallVector<int> Mask(VTy->getElementCount().getKnownMinValue(), 0);
+      return createBinOpShuffle(NewLHS, NewRHS, Mask);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -2286,13 +2286,9 @@ Instruction *InstCombinerImpl::foldVectorBinop(BinaryOperator &Inst) {`
`2286`	`2286`
`2287`	`2287`	`Value *NewLHS = ConstOp1 ? V1 : NewC;`
`2288`	`2288`	`Value *NewRHS = ConstOp1 ? NewC : V1;`
`2289`		`- Value *XY = Builder.CreateBinOp(Opcode, NewLHS, NewRHS);`
`2290`		`- if (auto *BO = dyn_cast<BinaryOperator>(XY))`
`2291`		`- BO->copyIRFlags(&Inst);`
`2292`		`-`
`2293`	`2289`	`VectorType *VTy = cast<VectorType>(Inst.getType());`
`2294`		`- SmallVector<int> NewM(VTy->getElementCount().getKnownMinValue(), 0);`
`2295`		`- return new ShuffleVectorInst(XY, NewM);`
	`2290`	`+ SmallVector<int> Mask(VTy->getElementCount().getKnownMinValue(), 0);`
	`2291`	`+ return createBinOpShuffle(NewLHS, NewRHS, Mask);`
`2296`	`2292`	`}`
`2297`	`2293`	`}`
`2298`	`2294`