Skip to content

Commit 405403c

Browse files
[mlir] Fix GCC compilation warning in TuneExtensionOps.cpp (#168850)
Building with GCC produces: ``` <...>/TuneExtensionOps.cpp:180:26: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 180 | if (*selectedRegionIdx < 0 || *selectedRegionIdx >= getNumRegions()) | ~~~~~~~~~~~~~~~~~~~^~~ <...>/TuneExtensionOps.cpp: In member function ‘llvm::LogicalResult mlir::transform::tune::AlternativesOp::verify()’: /home/david.spickett/llvm-project/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp:236:19: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 236 | if (regionIdx < 0 || regionIdx >= getNumRegions()) | ~~~~~~~~~~^~~ ``` As we are sign extending these variables, use int64_t instead of size_t for their type.
1 parent f9e0fa8 commit 405403c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ DiagnosedSilenceableFailure
156156
transform::tune::AlternativesOp::apply(transform::TransformRewriter &rewriter,
157157
transform::TransformResults &results,
158158
transform::TransformState &state) {
159-
std::optional<size_t> selectedRegionIdx;
159+
std::optional<int64_t> selectedRegionIdx;
160160

161161
if (auto selectedRegionAttr = getSelectedRegionAttr())
162162
selectedRegionIdx = selectedRegionAttr->getSExtValue();
@@ -232,7 +232,7 @@ LogicalResult transform::tune::AlternativesOp::verify() {
232232
}
233233

234234
if (auto selectedRegionAttr = getSelectedRegionAttr()) {
235-
size_t regionIdx = selectedRegionAttr->getSExtValue();
235+
int64_t regionIdx = selectedRegionAttr->getSExtValue();
236236
if (regionIdx < 0 || regionIdx >= getNumRegions())
237237
return emitOpError()
238238
<< "'selected_region' attribute specifies region at index "

0 commit comments

Comments
 (0)