Emit error message on the operation

Emit type conversion error message on the operation

Author: siddhesh195

mlir/lib/Conversion/LLVMCommon/Pattern.cpp

@@ -106,14 +106,8 @@ bool ConvertToLLVMPattern::isConvertibleAndHasIdentityMaps(
 
 Type ConvertToLLVMPattern::getElementPtrType(MemRefType type) const {
   auto addressSpace = getTypeConverter()->getMemRefAddressSpace(type);
-  if (failed(addressSpace)) {
-    emitError(UnknownLoc::get(type.getContext()),
-              "conversion of memref memory space ")
-        << type.getMemorySpace()
-        << " to integer address space "
-           "failed. Consider adding memory space conversions.";
+  if (failed(addressSpace))
     return {};
-  }
   return LLVM::LLVMPointerType::get(type.getContext(), *addressSpace);
 }
 

mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp

@@ -74,6 +74,12 @@ std::tuple<Value, Value> AllocationOpLLVMLowering::allocateBufferManuallyAlign(
   MemRefType memRefType = getMemRefResultType(op);
   // Allocate the underlying buffer.
   Type elementPtrType = this->getElementPtrType(memRefType);
+  if (!elementPtrType) {
+    emitError(loc,"conversion of memref memory space ")
+        << memRefType.getMemorySpace()
+        << " to integer address space "
+           "failed. Consider adding memory space conversions.";
+  }
   LLVM::LLVMFuncOp allocFuncOp = getNotalignedAllocFn(
       getTypeConverter(), op->getParentWithTrait<OpTrait::SymbolTable>(),
       getIndexType());

mlir/test/Conversion/MemRefToLLVM/invalid-uint.mlir

@@ -1,10 +1,8 @@
-// RUN: mlir-opt %s -finalize-memref-to-llvm 2>&1 | FileCheck %s
-// Since the error is at an unknown location, we use FileCheck instead of
-// -veri-y-diagnostics here
+// RUN: mlir-opt %s -finalize-memref-to-llvm -verify-diagnostics
 
-// CHECK: conversion of memref memory space 1 : ui64 to integer address space failed. Consider adding memory space conversions.
 // CHECK-LABEL: @invalid_int_conversion
 func.func @invalid_int_conversion() {
-     %alloc_0 = memref.alloc() {alignment = 64 : i64} : memref<10xf32, 1 : ui64>
+     // expected-error@+1 {{conversion of memref memory space 1 : ui64 to integer address space failed. Consider adding memory space conversions.}}
+     %alloc = memref.alloc() {alignment = 64 : i64} : memref<10xf32, 1 : ui64> 
     return
 }