add sema tests

Author: Keenuts

clang/include/clang/Basic/Attr.td

@@ -143,7 +143,7 @@ def SharedVar : SubsetSubject<Var,
 def HLSLInputBuiltin : SubsetSubject<Var, [{S->hasGlobalStorage() &&
                     S->getStorageClass()==StorageClass::SC_Static &&
                     S->getType().isConstQualified()}],
-                                     "input builtin">;
+                                     "static const globals">;
 
 def GlobalVar : SubsetSubject<Var,
                              [{S->hasGlobalStorage()}], "global variables">;
@@ -4915,7 +4915,7 @@ def HLSLWaveSize: InheritableAttr {
 
 def HLSLVkExtBuiltinInput : InheritableAttr {
   let Spellings = [CXX11<"vk", "ext_builtin_input">];
-  let Args = [IntArgument<"BuiltIn">];
+  let Args = [UnsignedArgument<"BuiltIn">];
   let Subjects = SubjectList<[HLSLInputBuiltin], ErrorDiag>;
   let LangOpts = [HLSL];
   let Documentation = [HLSLVkExtBuiltinInputDocs];

clang/lib/Sema/SemaHLSL.cpp

@@ -1070,9 +1070,11 @@ void SemaHLSL::handleWaveSizeAttr(Decl *D, const ParsedAttr &AL) {
 }
 
 void SemaHLSL::handleVkExtBuiltinInputAttr(Decl *D, const ParsedAttr &AL) {
-  IntegerLiteral *IL = cast<IntegerLiteral>(AL.getArgAsExpr(0));
-  D->addAttr(::new (getASTContext()) HLSLVkExtBuiltinInputAttr(
-      getASTContext(), AL, IL->getValue().getZExtValue()));
+  uint32_t ID;
+  if (!SemaRef.checkUInt32Argument(AL, AL.getArgAsExpr(0), ID))
+    return;
+  D->addAttr(::new (getASTContext())
+                 HLSLVkExtBuiltinInputAttr(getASTContext(), AL, ID));
 }
 
 bool SemaHLSL::diagnoseInputIDType(QualType T, const ParsedAttr &AL) {

clang/test/SemaHLSL/vk-ext-input-builtin.hlsl

@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -triple spirv-unkown-vulkan1.3-compute -x hlsl -hlsl-entry foo  -finclude-default-header -o - %s -verify
+
+// expected-error@+1 {{'ext_builtin_input' attribute only applies to static const globals}}
+[[vk::ext_builtin_input(/* WorkgroupId */ 26)]]
+const uint3 groupid1;
+
+// expected-error@+1 {{'ext_builtin_input' attribute only applies to static const globals}}
+[[vk::ext_builtin_input(/* WorkgroupId */ 26)]]
+static uint3 groupid2;
+
+// expected-error@+1 {{'ext_builtin_input' attribute takes one argument}}
+[[vk::ext_builtin_input()]]
+// expected-error@+1 {{default initialization of an object of const type 'const hlsl_private uint3' (aka 'const hlsl_private vector<uint, 3>')}}
+static const uint3 groupid3;
+
+// expected-error@+1 {{'ext_builtin_input' attribute requires an integer constant}}
+[[vk::ext_builtin_input(0.4f)]]
+// expected-error@+1 {{default initialization of an object of const type 'const hlsl_private uint3' (aka 'const hlsl_private vector<uint, 3>')}}
+static const uint3 groupid4;
+
+// expected-error@+1 {{'ext_builtin_input' attribute only applies to static const globals}}
+[[vk::ext_builtin_input(1)]]
+void some_function() {
+}
+
+[numthreads(1,1,1)]
+void foo() {
+}
+