Skip to content

Commit 42dd926

Browse files
committed
[libc++] Switch back to plotting on revlist order for visualize-historical
That provides vastly better plots.
1 parent 3fa3e09 commit 42dd926

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

libcxx/utils/visualize-historical

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,12 @@ def create_plot(data, metric, subtitle=None):
117117
Create a plot object showing the evolution of each benchmark throughout the given commits for
118118
the given metric.
119119
"""
120-
data = data.sort_values(by=['date', 'benchmark'])
120+
data = data.sort_values(by=['revlist_order', 'benchmark'])
121121
revlist = pandas.unique(data['commit']) # list of all commits in chronological order
122122
hover_info = {c: truncate_lines(c.show(), 30, marker='...').replace('\n', '<br>') for c in revlist}
123123
figure = plotly.express.scatter(data, title=f"{revlist[0].shortrev} to {revlist[-1].shortrev}",
124124
subtitle=subtitle,
125-
x='date', y=metric,
125+
x='revlist_order', y=metric,
126126
symbol='benchmark',
127127
color='benchmark',
128128
hover_name=[hover_info[c] for c in data['commit']],

0 commit comments

Comments
 (0)