do not bother with obsolete 64 interface with darwin

Author: devnexen

compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp

@@ -300,6 +300,7 @@ INTERCEPTOR(int, fstat, int fd, struct stat *s) {
   return REAL(fstat)(fd, s);
 }
 
+#if !SANITIZER_APPLE // deprecated for darwin
 INTERCEPTOR(int, stat64, const char *pathname, struct stat64 *s) {
   __rtsan_notify_intercepted_call("stat64");
   return REAL(stat64)(pathname, s);
@@ -314,6 +315,14 @@ INTERCEPTOR(int, fstat64, int fd, struct stat64 *s) {
   __rtsan_notify_intercepted_call("fstat64");
   return REAL(fstat64)(fd, s);
 }
+#define RTSAN_MAYBE_INTERCEPT_STAT64 INTERCEPTOR_FUNCTION(stat64)
+#define RTSAN_MAYBE_INTERCEPT_LSTAT64 INTERCEPTOR_FUNCTION(lstat64)
+#define RTSAN_MAYBE_INTERCEPT_FSTAT64 INTERCEPTOR_FUNCTION(fstat64)
+#else
+#define RTSAN_MAYBE_INTERCEPT_STAT64
+#define RTSAN_MAYBE_INTERCEPT_LSTAT64
+#define RTSAN_MAYBE_INTERCEPT_FSTAT64
+#endif
 
 // Streams
 
@@ -1470,9 +1479,9 @@ void __rtsan::InitializeInterceptors() {
   INTERCEPT_FUNCTION(stat);
   INTERCEPT_FUNCTION(lstat);
   INTERCEPT_FUNCTION(fstat);
-  INTERCEPT_FUNCTION(stat64);
-  INTERCEPT_FUNCTION(lstat64);
-  INTERCEPT_FUNCTION(fstat64);
+  RTSAN_MAYBE_INTERCEPT_STAT64;
+  RTSAN_MAYBE_INTERCEPT_LSTAT64;
+  RTSAN_MAYBE_INTERCEPT_FSTAT64;
   INTERCEPT_FUNCTION(fopen);
   RTSAN_MAYBE_INTERCEPT_FOPEN64;
   RTSAN_MAYBE_INTERCEPT_FREOPEN64;

compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp

@@ -880,16 +880,16 @@ TEST_F(RtsanOpenedFileTest, StatDiesWhenRealtime) {
     struct stat s{};
     stat(GetTemporaryFilePath(), &s);
   };
-  ExpectRealtimeDeath(Func, MAYBE_APPEND_64("stat"));
+  ExpectRealtimeDeath(Func, "stat");
   ExpectNonRealtimeSurvival(Func);
 }
 
-TEST_F(RtsanOpenedFileTest, LtatDiesWhenRealtime) {
+TEST_F(RtsanOpenedFileTest, LstatDiesWhenRealtime) {
   auto Func = [&]() {
     struct stat s{};
     lstat(GetTemporaryFilePath(), &s);
   };
-  ExpectRealtimeDeath(Func, MAYBE_APPEND_64("lstat"));
+  ExpectRealtimeDeath(Func, "lstat");
   ExpectNonRealtimeSurvival(Func);
 }
 
@@ -898,10 +898,39 @@ TEST_F(RtsanOpenedFileTest, FstatDiesWhenRealtime) {
     struct stat s{};
     fstat(GetOpenFd(), &s);
   };
-  ExpectRealtimeDeath(Func, MAYBE_APPEND_64("fstat"));
+  ExpectRealtimeDeath(Func, "fstat");
   ExpectNonRealtimeSurvival(Func);
 }
 
+#if !SANITIZER_APPLE // deprecated for darwin
+TEST_F(RtsanOpenedFileTest, Stat64DiesWhenRealtime) {
+  auto Func = [&]() {
+    struct stat64 s{};
+    stat64(GetTemporaryFilePath(), &s);
+  };
+  ExpectRealtimeDeath(Func, "stat");
+  ExpectNonRealtimeSurvival(Func);
+}
+
+TEST_F(RtsanOpenedFileTest, Lstat64DiesWhenRealtime) {
+  auto Func = [&]() {
+    struct stat64 s{};
+    lstat64(GetTemporaryFilePath(), &s);
+  };
+  ExpectRealtimeDeath(Func, "lstat64");
+  ExpectNonRealtimeSurvival(Func);
+}
+
+TEST_F(RtsanOpenedFileTest, Fstat64DiesWhenRealtime) {
+  auto Func = [&]() {
+    struct stat64 s{};
+    fstat64(GetOpenFd(), &s);
+  };
+  ExpectRealtimeDeath(Func, "fstat64");
+  ExpectNonRealtimeSurvival(Func);
+}
+#endif
+
 TEST_F(RtsanFileTest, FcloseDiesWhenRealtime) {
   FILE *f = fopen(GetTemporaryFilePath(), "w");
   EXPECT_THAT(f, Ne(nullptr));