Address a comment.

kazutakahirata · kazutakahirata · commit 4380641a1ac3 · 2025-06-25T08:08:00.000-07:00
diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -250,10 +250,10 @@ CleanupPointerRootUsers(GlobalVariable *GV,
     }
   }
 
-  for (const auto [I, Store] : Dead) {
-    if (IsSafeComputationToRemove(Pair.first, GetTLI)) {
-      Pair.second->eraseFromParent();
-      Instruction *I = Pair.first;
+  for (const auto &[Inst, Store] : Dead) {
+    if (IsSafeComputationToRemove(Inst, GetTLI)) {
+      Store->eraseFromParent();
+      Instruction *I = Inst;
       do {
         if (isAllocationFn(I, GetTLI))
           break;

Original file line number	Diff line number	Diff line change
`@@ -250,10 +250,10 @@ CleanupPointerRootUsers(GlobalVariable *GV,`
`250`	`250`	`}`
`251`	`251`	`}`
`252`	`252`
`253`		`- for (const auto [I, Store] : Dead) {`
`254`		`- if (IsSafeComputationToRemove(Pair.first, GetTLI)) {`
`255`		`- Pair.second->eraseFromParent();`
`256`		`- Instruction *I = Pair.first;`
	`253`	`+ for (const auto &[Inst, Store] : Dead) {`
	`254`	`+ if (IsSafeComputationToRemove(Inst, GetTLI)) {`
	`255`	`+ Store->eraseFromParent();`
	`256`	`+ Instruction *I = Inst;`
`257`	`257`	`do {`
`258`	`258`	`if (isAllocationFn(I, GetTLI))`
`259`	`259`	`break;`