Skip to content

Commit 4416e36

Browse files
committed
address comments
1 parent 2db7de1 commit 4416e36

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

mlir/lib/Target/LLVMIR/Dialect/Ptr/PtrToLLVMIRTranslation.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,21 @@ class PtrDialectLLVMIRTranslationInterface
3333
LogicalResult
3434
convertOperation(Operation *op, llvm::IRBuilderBase &builder,
3535
LLVM::ModuleTranslation &moduleTranslation) const final {
36-
return failure();
36+
// Translation for ptr dialect operations to LLVM IR is currently
37+
// unimplemented.
38+
return op->emitError("Translation for ptr dialect operations to LLVM IR is "
39+
"not implemented.");
3740
}
3841

3942
/// Attaches module-level metadata for functions marked as kernels.
4043
LogicalResult
4144
amendOperation(Operation *op, ArrayRef<llvm::Instruction *> instructions,
4245
NamedAttribute attribute,
4346
LLVM::ModuleTranslation &moduleTranslation) const final {
44-
return success();
47+
// Translation for ptr dialect operations to LLVM IR is currently
48+
// unimplemented.
49+
return op->emitError("Translation for ptr dialect operations to LLVM IR is "
50+
"not implemented.");
4551
}
4652
};
4753
} // namespace

0 commit comments

Comments
 (0)