[Clang][NFC] Explicitly delete copy ctor and assignment for CGAtomicOptionsRAII

shafik · shafik · commit 445b897f5b16 · 2025-04-24T17:23:54.000-07:00
Static analysis flagged CGAtomicOptionsRAII as having an explicit destructor
but not having explict copy ctor and assignment. Rule of three says we should.
We are just using this as an RAII object, no need for either so they will be
specified as deleted.
diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h
@@ -869,6 +869,9 @@ class CodeGenFunction : public CodeGenTypeCache {
       }
       CGM.setAtomicOpts(AO);
     }
+
+    CGAtomicOptionsRAII(const CGAtomicOptionsRAII &) = delete;
+    CGAtomicOptionsRAII &operator=(const CGAtomicOptionsRAII &) = delete;
     ~CGAtomicOptionsRAII() { CGM.setAtomicOpts(SavedAtomicOpts); }
 
   private:

Original file line number	Diff line number	Diff line change
`@@ -869,6 +869,9 @@ class CodeGenFunction : public CodeGenTypeCache {`
`869`	`869`	`}`
`870`	`870`	`CGM.setAtomicOpts(AO);`
`871`	`871`	`}`
	`872`	`+`
	`873`	`+ CGAtomicOptionsRAII(const CGAtomicOptionsRAII &) = delete;`
	`874`	`+ CGAtomicOptionsRAII &operator=(const CGAtomicOptionsRAII &) = delete;`
`872`	`875`	`~CGAtomicOptionsRAII() { CGM.setAtomicOpts(SavedAtomicOpts); }`
`873`	`876`
`874`	`877`	`private:`