chore: make forEachAttr static after review feedback

Wheest · Wheest · commit 446380a8562b · 2025-10-14T09:05:11.000+01:00
diff --git a/mlir/lib/Bindings/Python/IRCore.cpp b/mlir/lib/Bindings/Python/IRCore.cpp
@@ -2730,7 +2730,8 @@ class PyOpAttributeMap {
         operation->get(), toMlirStringRef(name)));
   }
 
-  void forEachAttr(llvm::function_ref<void(MlirStringRef, MlirAttribute)> fn) {
+  static void
+  forEachAttr(llvm::function_ref<void(MlirStringRef, MlirAttribute)> fn) {
     intptr_t n = mlirOperationGetNumAttributes(operation->get());
     for (intptr_t i = 0; i < n; ++i) {
       MlirNamedAttribute na = mlirOperationGetAttribute(operation->get(), i);

Original file line number	Diff line number	Diff line change
`@@ -2730,7 +2730,8 @@ class PyOpAttributeMap {`
`2730`	`2730`	`operation->get(), toMlirStringRef(name)));`
`2731`	`2731`	`}`
`2732`	`2732`
`2733`		`- void forEachAttr(llvm::function_ref<void(MlirStringRef, MlirAttribute)> fn) {`
	`2733`	`+ static void`
	`2734`	`+ forEachAttr(llvm::function_ref<void(MlirStringRef, MlirAttribute)> fn) {`
`2734`	`2735`	`intptr_t n = mlirOperationGetNumAttributes(operation->get());`
`2735`	`2736`	`for (intptr_t i = 0; i < n; ++i) {`
`2736`	`2737`	`MlirNamedAttribute na = mlirOperationGetAttribute(operation->get(), i);`