Skip to content

Commit 4468af2

Browse files
committed
[lldb-dap] Experimenting with async in DAP tests.
This is not fully tested yet, but the basic approach is to remove the background thread that can cause races in the tests. Instead, I am using an asyncio event loop to read packets, and the tests can await on the loop to process packets as needed. With further refactoring we should be able to push the async operations further up the stack into the test cases themselves.
1 parent c422881 commit 4468af2

File tree

10 files changed

+583
-640
lines changed

10 files changed

+583
-640
lines changed

lldb/packages/Python/lldbsuite/test/dotest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ def parseOptionsAndInitTestdirs():
300300
configuration.libcxx_include_target_dir = args.libcxx_include_target_dir
301301
configuration.libcxx_library_dir = args.libcxx_library_dir
302302

303-
configuration.cmake_build_type = args.cmake_build_type.lower()
303+
if args.cmake_build_type:
304+
configuration.cmake_build_type = args.cmake_build_type.lower()
304305

305306
if args.channels:
306307
lldbtest_config.channels = args.channels

0 commit comments

Comments
 (0)