Use ASCII flag

Author: Jlalond

lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

@@ -695,7 +695,6 @@ Status MinidumpFileBuilder::AddExceptions() {
 
     RegisterContextSP reg_ctx_sp(thread_sp->GetRegisterContext());
     Exception exp_record = {};
-    exp_record.ExceptionCode = static_cast<llvm::support::ulittle32_t>(stop_info_sp->GetValue());
     exp_record.ExceptionCode =
         static_cast<llvm::support::ulittle32_t>(stop_info_sp->GetValue());
     exp_record.ExceptionFlags = static_cast<llvm::support::ulittle32_t>(Exception::LLDB_FLAG);

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

@@ -274,7 +274,7 @@ void ProcessMinidump::RefreshStateAfterStop() {
         return;
       }
       const char * description = nullptr;
-      if ((exception_stream.ExceptionRecord.ExceptionFlags & llvm::minidump::Exception::LLDB_FLAG) == llvm::minidump::Exception::LLDB_FLAG)
+      if (exception_stream.ExceptionRecord.ExceptionFlags == llvm::minidump::Exception::LLDB_FLAG)
         description = reinterpret_cast<const char *>(exception_stream.ExceptionRecord.ExceptionInformation);
 
       stop_info = StopInfo::CreateStopReasonWithSignal(*stop_thread, signo, description);

llvm/include/llvm/BinaryFormat/Minidump.h

@@ -247,7 +247,7 @@ static_assert(sizeof(Thread) == 48);
 struct Exception {
   static constexpr size_t MaxParameters = 15;
   static constexpr size_t MaxParameterBytes = MaxParameters * sizeof(uint64_t);
-  static const uint32_t LLDB_FLAG = 0x80000000;
+  static const uint32_t LLDB_FLAG = 'LLDB';
 
   support::ulittle32_t ExceptionCode;
   support::ulittle32_t ExceptionFlags;