Address code review comments

Author: AmrDeveloper

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -2843,6 +2843,9 @@ def CIR_ComplexMulOp : CIR_Op<"complex.mul", [
     The `cir.complex.mul` operation takes two complex numbers and returns
     their product.
 
+    Range is used to controls the various implementations for complex
+    multiplication.
+
     Example:
 
     ```mlir

clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp

@@ -651,6 +651,7 @@ getComplexRangeAttr(LangOptions::ComplexRangeKind range) {
   case LangOptions::CX_Basic:
     return cir::ComplexRangeKind::Basic;
   case LangOptions::CX_None:
+    // The default value for ComplexRangeKind is Full is no option is selected
     return cir::ComplexRangeKind::Full;
   }
 }

clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp

@@ -44,7 +44,7 @@ struct LoweringPreparePass : public LoweringPrepareBase<LoweringPreparePass> {
   clang::ASTContext *astCtx;
 
   /// Tracks current module.
-  mlir::ModuleOp theModule;
+  mlir::ModuleOp mlirModule;
 
   void setASTContext(clang::ASTContext *c) { astCtx = c; }
 };
@@ -55,7 +55,7 @@ cir::FuncOp LoweringPreparePass::buildRuntimeFunction(
     mlir::OpBuilder &builder, llvm::StringRef name, mlir::Location loc,
     cir::FuncType type, cir::GlobalLinkageKind linkage) {
   cir::FuncOp f = dyn_cast_or_null<FuncOp>(SymbolTable::lookupNearestSymbolFrom(
-      theModule, StringAttr::get(theModule->getContext(), name)));
+      mlirModule, StringAttr::get(mlirModule->getContext(), name)));
   if (!f) {
     f = builder.create<cir::FuncOp>(loc, name, type);
     f.setLinkageAttr(
@@ -167,10 +167,12 @@ static mlir::Value buildComplexBinOpLibCall(
 
   cir::FuncType libFuncTy = cir::FuncType::get(libFuncInputTypes, ty);
 
+  // Inserting a declaration for the runtime function to be used in Complex
+  // multiplication and division when needed
   cir::FuncOp libFunc;
   {
     mlir::OpBuilder::InsertionGuard ipGuard{builder};
-    builder.setInsertionPointToStart(pass.theModule.getBody());
+    builder.setInsertionPointToStart(pass.mlirModule.getBody());
     libFunc = pass.buildRuntimeFunction(builder, libFuncName, loc, libFuncTy);
   }
 
@@ -228,6 +230,8 @@ static mlir::Value lowerComplexMul(LoweringPreparePass &pass,
       rangeKind == cir::ComplexRangeKind::Promoted)
     return algebraicResult;
 
+  assert(!cir::MissingFeatures::fastMathFlags());
+
   // Check whether the real part and the imaginary part of the result are both
   // NaN. If so, emit a library call to compute the multiplication instead.
   // We check a value against NaN by comparing the value against itself.
@@ -416,9 +420,8 @@ void LoweringPreparePass::runOnOp(mlir::Operation *op) {
 
 void LoweringPreparePass::runOnOperation() {
   mlir::Operation *op = getOperation();
-  if (isa<::mlir::ModuleOp>(op)) {
-    theModule = cast<::mlir::ModuleOp>(op);
-  }
+  if (isa<::mlir::ModuleOp>(op))
+    mlirModule = cast<::mlir::ModuleOp>(op);
 
   llvm::SmallVector<mlir::Operation *> opsToTransform;