Simplify return and break cmd

Author: IgWod-IMG

mlir/lib/Target/SPIRV/TranslateRegistration.cpp

@@ -97,22 +97,19 @@ serializeModule(spirv::ModuleOp moduleOp, raw_ostream &output,
     if (dirSeparator != std::string::npos) {
       llvm::StringRef parentDir =
           llvm::sys::path::parent_path(options.validationFilePrefix);
-      if (!llvm::sys::fs::is_directory(parentDir)) {
-        moduleOp.emitError("validation prefix directory does not exist\n");
-        return failure();
-      }
+      if (!llvm::sys::fs::is_directory(parentDir))
+        return moduleOp.emitError(
+            "validation prefix directory does not exist\n");
     }
 
     SmallString<128> filename;
     int fd = 0;
 
     std::error_code errorCode = llvm::sys::fs::createUniqueFile(
         options.validationFilePrefix + "%%%%%%", fd, filename);
-    if (errorCode) {
-      moduleOp.emitError("error creating validation output file: ")
-          << errorCode.message() << "\n";
-      return failure();
-    }
+    if (errorCode)
+      return moduleOp.emitError("error creating validation output file: ")
+             << errorCode.message() << "\n";
 
     llvm::raw_fd_ostream validationOutput(fd, /*shouldClose=*/true);
     validationOutput.write(reinterpret_cast<char *>(binary.data()),

mlir/test/Target/SPIRV/mlir-translate.mlir

@@ -3,7 +3,9 @@
 
 // REQUIRES: shell
 // RUN: rm -rf %t
-// RUN: mkdir %t && mlir-translate --serialize-spirv --no-implicit-module --split-input-file --spirv-save-validation-files-with-prefix=%t/foo %s && ls %t | wc -l | FileCheck %s
+// RUN: mkdir %t && mlir-translate --serialize-spirv --no-implicit-module \
+// RUN: --split-input-file --spirv-save-validation-files-with-prefix=%t/foo %s \
+// RUN: && ls %t | wc -l | FileCheck %s
 // RUN: rm -rf %t
 
 // CHECK: 4