[llvm][unittests] Don't call raw_string_ostream::flush() (NFC)

raw_string_ostream::flush() is essentially a no-op (also specified in docs).
Don't call it in tests that aren't meant to test 'raw_string_ostream' itself.

p.s. remove a few redundant calls to raw_string_ostream::str()

Author: JOE1994

llvm/unittests/ADT/RewriteBufferTest.cpp

@@ -19,7 +19,6 @@ static std::string writeOutput(const RewriteBuffer &Buf) {
   std::string Result;
   raw_string_ostream OS(Result);
   Buf.write(OS);
-  OS.flush();
   return Result;
 }
 

llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp

@@ -44,7 +44,6 @@ void expectDumpResult(const dwarf::CIE &TestCIE, bool IsEH,
   auto DumpOpts = DIDumpOptions();
   DumpOpts.IsEH = IsEH;
   TestCIE.dump(OS, DumpOpts);
-  OS.flush();
   StringRef FirstLine = StringRef(Output).split('\n').first;
   EXPECT_EQ(FirstLine, ExpectedFirstLine);
 }
@@ -56,7 +55,6 @@ void expectDumpResult(const dwarf::FDE &TestFDE, bool IsEH,
   auto DumpOpts = DIDumpOptions();
   DumpOpts.IsEH = IsEH;
   TestFDE.dump(OS, DumpOpts);
-  OS.flush();
   StringRef FirstLine = StringRef(Output).split('\n').first;
   EXPECT_EQ(FirstLine, ExpectedFirstLine);
 }
@@ -344,7 +342,6 @@ void expectDumpResult(const dwarf::UnwindLocation &Loc,
   std::string Output;
   raw_string_ostream OS(Output);
   OS << Loc;
-  OS.flush();
   StringRef FirstLine = StringRef(Output).split('\n').first;
   EXPECT_EQ(FirstLine, ExpectedFirstLine);
 }
@@ -387,7 +384,6 @@ void expectDumpResult(const dwarf::RegisterLocations &Locs,
   std::string Output;
   raw_string_ostream OS(Output);
   OS << Locs;
-  OS.flush();
   StringRef FirstLine = StringRef(Output).split('\n').first;
   EXPECT_EQ(FirstLine, ExpectedFirstLine);
 }

llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

@@ -1558,7 +1558,6 @@ TEST_F(DebugLineBasicFixture, VerboseOutput) {
   raw_string_ostream OS(Output);
   Parser.parseNext(RecordRecoverable, RecordUnrecoverable, &OS,
                    /*Verbose=*/true);
-  OS.flush();
   StringRef OutputRef(Output);
 
   size_t Pos = 0;
@@ -1805,7 +1804,6 @@ struct TruncatedOpcodeFixtureBase : public CommonFixture {
     raw_string_ostream OS(Output);
     Parser.parseNext(RecordRecoverable, RecordUnrecoverable, &OS,
                      /*Verbose=*/true);
-    OS.flush();
 
     std::string LinePrefix =
         ("0x0000002f: 0" + Twine::utohexstr(OpcodeValue) + " ").str();

llvm/unittests/DebugInfo/DWARF/DWARFFormValueTest.cpp

@@ -375,7 +375,6 @@ TEST_P(DumpValueFixture, Test) {
   Opts.ShowAddresses = true;
 
   Form.dump(OS, Opts);
-  OS.flush();
 
   EXPECT_EQ(Output, ExpectedResult);
 }

llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

@@ -3802,7 +3802,6 @@ TEST(GSYMTest, TestRangeWarnings) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;
@@ -4005,7 +4004,6 @@ TEST(GSYMTest, TestEmptyRangeWarnings) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;
@@ -4158,7 +4156,6 @@ TEST(GSYMTest, TestEmptyLinkageName) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;
@@ -4320,7 +4317,6 @@ TEST(GSYMTest, TestLineTablesWithEmptyRanges) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;
@@ -4641,7 +4637,6 @@ TEST(GSYMTest, TestHandlingOfInvalidFileIndexes) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;
@@ -4857,7 +4852,6 @@ TEST(GSYMTest, TestLookupsOfOverlappingAndUnequalRanges) {
   const uint32_t ThreadCount = 1;
   ASSERT_THAT_ERROR(DT.convert(ThreadCount, OSAgg), Succeeded());
   ASSERT_THAT_ERROR(GC.finalize(OSAgg), Succeeded());
-  OS.flush();
   SmallString<512> Str;
   raw_svector_ostream OutStrm(Str);
   const auto ByteOrder = llvm::endianness::native;

llvm/unittests/IR/ConstantsTest.cpp

@@ -172,7 +172,6 @@ TEST(ConstantsTest, PointerCast) {
     Instruction *__I = cast<ConstantExpr>(x)->getAsInstruction();              \
     __I->print(__o);                                                           \
     __I->deleteValue();                                                        \
-    __o.flush();                                                               \
     EXPECT_EQ(std::string("  <badref> = " y), __s);                            \
   }
 

llvm/unittests/IR/ManglerTest.cpp

@@ -20,7 +20,6 @@ static std::string mangleStr(StringRef IRName, Mangler &Mang,
   std::string Mangled;
   raw_string_ostream SS(Mangled);
   Mang.getNameWithPrefix(SS, IRName, DL);
-  SS.flush();
   return Mangled;
 }
 
@@ -37,7 +36,6 @@ static std::string mangleFunc(StringRef IRName,
   std::string Mangled;
   raw_string_ostream SS(Mangled);
   Mang.getNameWithPrefix(SS, F, false);
-  SS.flush();
   F->eraseFromParent();
   return Mangled;
 }

llvm/unittests/IR/MetadataTest.cpp

@@ -299,7 +299,6 @@ TEST_F(MDNodeTest, Print) {
     std::string Actual_;                                                       \
     raw_string_ostream OS(Actual_);                                            \
     PRINT;                                                                     \
-    OS.flush();                                                                \
     std::string Expected_(EXPECTED);                                           \
     EXPECT_EQ(Expected_, Actual_);                                             \
   } while (false)

llvm/unittests/IR/ModuleSummaryIndexTest.cpp

@@ -45,7 +45,6 @@ TEST(ModuleSummaryIndexTest, MemProfSummaryPrinting) {
   for (auto &AI : AllocSummary->allocs())
     OS << "\n" << AI;
 
-  OS.flush();
   EXPECT_EQ(Data, R"(
 Callee: 23 Clones: 0 StackIds: 2, 3
 Callee: 23 Clones: 0 StackIds: 2, 4

llvm/unittests/MC/MCInstPrinter.cpp

@@ -53,7 +53,6 @@ class MCInstPrinterTest : public ::testing::Test {
     std::string Buffer;
     raw_string_ostream OS(Buffer);
     OS << Printer->formatHex(i);
-    OS.flush();
     return Buffer;
   }
 };