Skip to content

Commit 45abd19

Browse files
committed
review: fix up comments
1 parent 8cec5aa commit 45abd19

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

llvm/docs/DirectX/DXILArchitecture.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Each of these passes has a defined responsibility:
122122
namely removing attributes, and inserting bitcasts to allow typed pointers
123123
to be inserted.
124124
#. DXILTranslateMetadata transforms and emits all recognized DXIL Metadata.
125-
#. DXILValidateMetadata validates all emitted DXIL metadata structures
125+
#. DXILValidateMetadata validates that all emitted DXIL metadata structures
126126
conform to DXIL validation.
127127

128128
The passes to encode DXIL to binary in the DX Container follow the flow:

llvm/lib/Target/DirectX/DXILValidateMetadata.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ using namespace llvm;
2828

2929
namespace {
3030

31-
/// A simple Wrapper DiagnosticInfo that generates Module-level diagnostic
32-
/// for the ValidateMetadata pass
31+
/// A simple wrapper of DiagnosticInfo that generates module-level diagnostic
32+
/// for the DXILValidateMetadata pass
3333
class DiagnosticInfoValidateMD : public DiagnosticInfo {
3434
private:
3535
const Twine &Msg;
@@ -70,7 +70,7 @@ static void validateLoopMetadata(Module &M, MDNode *LoopMD) {
7070
"llvm.loop.unroll.disable",
7171
"llvm.loop.unroll.full"};
7272

73-
// llvm.loop metadata must have it's first operand be a self-reference, so we
73+
// llvm.loop metadata must have its first operand be a self-reference, so we
7474
// require at least 1 operand.
7575
//
7676
// It only makes sense to specify up to 1 of the hints on a branch, so we can

llvm/lib/Target/DirectX/DXILValidateMetadata.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===- DXILValidateMetadata.h - Pass to emit DXIL metadata -----*- C++ -*-===//
1+
//===- DXILValidateMetadata.h - Pass to validate DXIL metadata --*- C++ -*-===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
@@ -13,7 +13,7 @@
1313

1414
namespace llvm {
1515

16-
/// A pass that transforms DXIL Intrinsics that don't have DXIL opCodes
16+
/// A pass that validates metadata to be DXIL compatible
1717
class DXILValidateMetadata : public PassInfoMixin<DXILValidateMetadata> {
1818
public:
1919
PreservedAnalyses run(Module &M, ModuleAnalysisManager &);

0 commit comments

Comments
 (0)