Skip to content

Commit 45d5e7b

Browse files
authored
[lldb][NFC] Mark ValueObject library with NO_PLUGIN_DEPENDENCIES (#167794)
The ValueObject library doesn't actually depend on any plugins currently, but it links against the C++ and ObjC language plugins. I removed those and added NO_PLUGIN_DEPENDENCIES. However, the build failed initally because the Commands library depends on clangFrontend and it was previously getting it transitively through ValueObject -> C++/ObjC Language -> clangFrontend. This makes the dependency more explicit.
1 parent 897cc3e commit 45d5e7b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lldb/source/Commands/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ add_lldb_library(lldbCommands NO_PLUGIN_DEPENDENCIES
5858
lldbUtility
5959
lldbValueObject
6060
lldbVersion
61+
CLANG_LIBS
62+
clangFrontend
6163
)
6264

6365
add_dependencies(lldbCommands LLDBOptionsGen)

lldb/source/ValueObject/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
add_lldb_library(lldbValueObject
1+
add_lldb_library(lldbValueObject NO_PLUGIN_DEPENDENCIES
22
DILAST.cpp
33
DILEval.cpp
44
DILLexer.cpp
@@ -34,6 +34,4 @@ add_lldb_library(lldbValueObject
3434
lldbSymbol
3535
lldbTarget
3636
lldbUtility
37-
lldbPluginCPlusPlusLanguage
38-
lldbPluginObjCLanguage
3937
)

0 commit comments

Comments
 (0)