Skip to content

Commit 46175f5

Browse files
committed
Address review comments.
1 parent 140a3aa commit 46175f5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

mlir/include/mlir/Dialect/XeGPU/uArch/uArchBase.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,16 @@ enum class InstructionKind {
3737
// @TODO: Add more instructions as needed
3838
};
3939

40-
llvm::StringRef toString(InstructionKind name) {
40+
static llvm::StringRef toString(InstructionKind name) {
4141
switch (name) {
4242
case InstructionKind::DPAS:
4343
return "dpas";
4444
}
4545
llvm_unreachable("Unknown InstructionKind");
4646
}
4747

48-
std::optional<InstructionKind> parseInstructionKind(llvm::StringRef str) {
48+
static std::optional<InstructionKind>
49+
parseInstructionKind(llvm::StringRef str) {
4950
if (str.equals_insensitive("dpas"))
5051
return InstructionKind::DPAS;
5152
return std::nullopt;

0 commit comments

Comments
 (0)