addressing comments

Author: joaosaffran

llvm/include/llvm/MC/DXContainerRootSignature.h

@@ -6,9 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "llvm/ADT/STLForwardCompat.h"
 #include "llvm/BinaryFormat/DXContainer.h"
-#include <cstddef>
 #include <cstdint>
 #include <optional>
 #include <utility>

llvm/lib/MC/DXContainerRootSignature.cpp

@@ -8,9 +8,7 @@
 
 #include "llvm/MC/DXContainerRootSignature.h"
 #include "llvm/ADT/SmallString.h"
-#include "llvm/BinaryFormat/DXContainer.h"
 #include "llvm/Support/EndianStream.h"
-#include <variant>
 
 using namespace llvm;
 using namespace llvm::mcdxbc;

llvm/lib/ObjectYAML/DXContainerEmitter.cpp

@@ -298,11 +298,13 @@ void DXContainerWriter::writeParts(raw_ostream &OS) {
             Descriptor.RegisterSpace = Param.Descriptor.RegisterSpace;
             Descriptor.ShaderRegister = Param.Descriptor.ShaderRegister;
             Descriptor.Flags = Param.Descriptor.getEncodedFlags();
-          RS.ParametersContainer.addParameter(Header, Descriptor);
+            RS.ParametersContainer.addParameter(Header, Descriptor);
           }
           break;
         default:
-          // Handling invalid parameter type edge case
+          // Handling invalid parameter type edge case. We intentionally let
+          // obj2yaml/yaml2obj parse and emit invalid dxcontainer data, in order
+          // for that to be used as a testing tool more effectively.
           RS.ParametersContainer.addInfo(Header, -1);
         }
       }

llvm/lib/Target/DirectX/DXILRootSignature.cpp

@@ -30,7 +30,6 @@
 #include <cstdint>
 #include <optional>
 #include <utility>
-#include <variant>
 
 using namespace llvm;
 using namespace llvm::dxil;