Skip to content

Commit 46d3e64

Browse files
committed
Propoagte type from getTypeWidth and int64_t
1 parent 7a9d429 commit 46d3e64

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2368,10 +2368,11 @@ struct AMDGPUMakeDmaDescriptorLowering
23682368
ConversionPatternRewriter &rewriter, Location loc,
23692369
Value sgpr0, ArrayRef<Value> consts) const {
23702370
// Compute data_size.
2371-
int elementTypeWidthInBits = op.getElementTypeWidth();
2372-
assert(llvm::is_contained({8, 16, 32, 64}, elementTypeWidthInBits) &&
2373-
"expected type width to be 8, 16, 32, or 64.");
2374-
int dataSize = llvm::Log2_32(elementTypeWidthInBits / 8);
2371+
unsigned elementTypeWidthInBits = op.getElementTypeWidth();
2372+
assert(
2373+
llvm::is_contained<unsigned>({8, 16, 32, 64}, elementTypeWidthInBits) &&
2374+
"expected type width to be 8, 16, 32, or 64.");
2375+
int64_t dataSize = llvm::Log2_32(elementTypeWidthInBits / 8);
23752376
return createI32Constant(rewriter, loc, dataSize << 16);
23762377
}
23772378

mlir/lib/Dialect/AMDGPU/IR/AMDGPUDialect.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -759,8 +759,8 @@ LogicalResult MakeDmaDescriptorOp::verify() {
759759
if (rank != sharedStaticSizes.size())
760760
return emitOpError("tensor must have same rank as tile.");
761761

762-
int elementTypeWidth = getElementTypeWidth();
763-
if (!llvm::is_contained({8, 16, 32, 64}, elementTypeWidth))
762+
unsigned elementTypeWidth = getElementTypeWidth();
763+
if (!llvm::is_contained<unsigned>({8, 16, 32, 64}, elementTypeWidth))
764764
return emitOpError(
765765
"element type width must be 1, 2, 4 or 8 bytes, but was ")
766766
<< elementTypeWidth << " bits long";

0 commit comments

Comments
 (0)