Fixes for review

Author: ylzsx

lld/ELF/Arch/LoongArch.cpp

@@ -1014,8 +1014,8 @@ static bool relax(Ctx &ctx, InputSection &sec) {
 //  * ld.d      $a0, $a0, %ie_pc_lo12(sym)
 //
 // The code sequence converted is as follows:
-//  * lu12i.w   $a0, %le_hi20(sym)  # le_hi20 != 0, otherwise NOP
-//  * ori $a0   $a0, %le_lo12(sym)
+//  * lu12i.w   $a0, %le_hi20(sym)      # le_hi20 != 0, otherwise NOP
+//  * ori       $a0, src, %le_lo12(sym) # le_hi20 != 0, src = $a0, otherwise src = $zero
 //
 // When relaxation enables, redundant NOPs can be removed.
 void LoongArch::tlsIeToLe(uint8_t *loc, const Relocation &rel,
@@ -1036,7 +1036,7 @@ void LoongArch::tlsIeToLe(uint8_t *loc, const Relocation &rel,
   case R_LARCH_TLS_IE_PC_LO12:
     if (isUInt12)
       write32le(loc, insn(ORI, getD5(currInsn), R_ZERO,
-                          val)); // ori $a0, $r0, %le_lo12
+                          val)); // ori $a0, $zero, %le_lo12
     else
       write32le(loc, insn(ORI, getD5(currInsn), getJ5(currInsn),
                           lo12(val))); // ori $a0, $a0, %le_lo12
@@ -1064,7 +1064,7 @@ void LoongArch::relocateAlloc(InputSectionBase &sec, uint8_t *buf) const {
       continue;
     case R_RELAX_TLS_IE_TO_LE:
       if (rel.type == R_LARCH_TLS_IE_PC_HI20) {
-        // LoongArch does not support IE to LE optimize in the extreme code
+        // LoongArch does not support IE to LE optimization in the extreme code
         // model. In this case, the relocs are as follows:
         //
         //  * i   -- R_LARCH_TLS_IE_PC_HI20
@@ -1079,8 +1079,9 @@ void LoongArch::relocateAlloc(InputSectionBase &sec, uint8_t *buf) const {
         val = SignExtend64(sec.getRelocTargetVA(ctx, rel, secAddr + rel.offset),
                            bits);
         relocateNoSym(loc, rel.type, val);
-      } else
+      } else {
         tlsIeToLe(loc, rel, val);
+      }
       continue;
     default:
       break;

lld/ELF/Relocations.cpp

@@ -1375,7 +1375,7 @@ unsigned RelocationScanner::handleTlsRelocation(RelExpr expr, RelType type,
     return 1;
   }
 
-  // LoongArch support IE to LE optimization in non-extreme code model.
+  // LoongArch supports IE to LE optimization in non-extreme code model.
   bool execOptimizeInLoongArch =
       ctx.arg.emachine == EM_LOONGARCH &&
       (type == R_LARCH_TLS_IE_PC_HI20 || type == R_LARCH_TLS_IE_PC_LO12);

lld/test/ELF/loongarch-relax-tls-ie.s

@@ -51,7 +51,7 @@ ld.d $a1, $a1, %ie_pc_lo12(b)
 add.d $a1, $a1, $tp
 
 # Test instructions are interleaved.
-# PCALAU12I has an R_LARCH_RELAX. We preform relaxation.
+# PCALAU12I has an R_LARCH_RELAX. We perform relaxation.
 pcalau12i $a2, %ie_pc_hi20(a)
 .reloc .-4, R_LARCH_RELAX, 0
 pcalau12i $a3, %ie_pc_hi20(b)