Skip to content

Commit 471ef62

Browse files
committed
Addressed the comments, except last Bazel one
1 parent 0faacb6 commit 471ef62

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

libc/src/__support/math/CMakeLists.txt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -764,11 +764,12 @@ add_header_library(
764764
HDRS
765765
rsqrtf.h
766766
DEPENDS
767-
libc.hdr.errno_macros
768-
libc.hdr.fenv_macros
769-
libc.src.__support.FPUtil.cast
770-
libc.src.__support.FPUtil.fenv_impl
771-
libc.src.__support.FPUtil.fp_bits
767+
libc.hdr.errno_macros
768+
libc.hdr.fenv_macros
769+
libc.src.__support.FPUtil.cast
770+
libc.src.__support.FPUtil.fenv_impl
771+
libc.src.__support.FPUtil.fp_bits
772+
libc.src.__support.FPUtil.sqrt
772773
libc.src.__support.macros.optimization
773774
)
774775

@@ -777,14 +778,13 @@ add_header_library(
777778
HDRS
778779
rsqrtf16.h
779780
DEPENDS
781+
libc.hdr.errno_macros
782+
libc.hdr.fenv_macros
780783
libc.src.__support.FPUtil.cast
781784
libc.src.__support.FPUtil.fenv_impl
782785
libc.src.__support.FPUtil.fp_bits
783-
libc.src.__support.FPUtil.multiply_add
784-
libc.src.__support.FPUtil.polyeval
785-
libc.src.__support.FPUtil.manipulation_functions
786+
libc.src.__support.FPUtil.sqrt
786787
libc.src.__support.macros.optimization
787-
libc.src.__support.macros.properties.types
788788
)
789789

790790
add_header_library(

libc/test/shared/shared_math_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ TEST(LlvmLibcSharedMathTest, AllFloat) {
6767

6868
ASSERT_FP_EQ(float(8 << 5), LIBC_NAMESPACE::shared::ldexpf(8.0f, 5));
6969
ASSERT_FP_EQ(float(-1 * (8 << 5)), LIBC_NAMESPACE::shared::ldexpf(-8.0f, 5));
70+
7071
EXPECT_FP_EQ(0x1p+0f, LIBC_NAMESPACE::shared::rsqrtf(1.0f));
7172
}
7273

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4513,7 +4513,6 @@ libc_math_function(
45134513
name = "rsqrtf16",
45144514
additional_deps = [
45154515
":__support_math_rsqrtf16",
4516-
":errno",
45174516
],
45184517
)
45194518

0 commit comments

Comments
 (0)