Skip to content

Commit 47691e6

Browse files
author
Sriya Pratipati
committed
fixed the errno checking in test file
1 parent 221846e commit 47691e6

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

libc/test/src/wchar/mbtowc_test.cpp

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
#include "test/UnitTest/ErrnoCheckingTest.h"
1313
#include "test/UnitTest/Test.h"
1414

15-
TEST(LlvmLibcMBToWC, OneByte) {
15+
using LlvmLibcMBToWCTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
16+
17+
TEST_F(LlvmLibcMBToWCTest, OneByte) {
1618
const char *ch = "A";
1719
wchar_t dest[2];
1820
int n = LIBC_NAMESPACE::mbtowc(dest, ch, 1);
@@ -25,7 +27,7 @@ TEST(LlvmLibcMBToWC, OneByte) {
2527
ASSERT_ERRNO_EQ(EILSEQ);
2628
}
2729

28-
TEST(LlvmLibcMBToWC, TwoByte) {
30+
TEST_F(LlvmLibcMBToWCTest, TwoByte) {
2931
const char ch[2] = {static_cast<char>(0xC2),
3032
static_cast<char>(0x8E)}; // Ž car symbol
3133
wchar_t dest[2];
@@ -42,7 +44,7 @@ TEST(LlvmLibcMBToWC, TwoByte) {
4244
ASSERT_ERRNO_EQ(EILSEQ);
4345
}
4446

45-
TEST(LlvmLibcMBToWC, ThreeByte) {
47+
TEST_F(LlvmLibcMBToWCTest, ThreeByte) {
4648
const char ch[3] = {static_cast<char>(0xE2), static_cast<char>(0x88),
4749
static_cast<char>(0x91)}; // ∑ sigma symbol
4850
wchar_t dest[2];
@@ -56,7 +58,7 @@ TEST(LlvmLibcMBToWC, ThreeByte) {
5658
ASSERT_ERRNO_EQ(EILSEQ);
5759
}
5860

59-
TEST(LlvmLibcMBToWC, FourByte) {
61+
TEST_F(LlvmLibcMBToWCTest, FourByte) {
6062
const char ch[4] = {static_cast<char>(0xF0), static_cast<char>(0x9F),
6163
static_cast<char>(0xA4),
6264
static_cast<char>(0xA1)}; // 🤡 clown emoji
@@ -71,15 +73,15 @@ TEST(LlvmLibcMBToWC, FourByte) {
7173
ASSERT_ERRNO_EQ(EILSEQ);
7274
}
7375

74-
TEST(LlvmLibcMBToWC, InvalidByte) {
76+
TEST_F(LlvmLibcMBToWCTest, InvalidByte) {
7577
const char ch[1] = {static_cast<char>(0x80)};
7678
wchar_t dest[2];
7779
int n = LIBC_NAMESPACE::mbtowc(dest, ch, 1);
7880
ASSERT_EQ(n, -1);
7981
ASSERT_ERRNO_EQ(EILSEQ);
8082
}
8183

82-
TEST(LlvmLibcMBToWC, InvalidMultiByte) {
84+
TEST_F(LlvmLibcMBToWCTest, InvalidMultiByte) {
8385
const char ch[4] = {static_cast<char>(0x80), static_cast<char>(0x00),
8486
static_cast<char>(0x80),
8587
static_cast<char>(0x00)}; // invalid sequence of bytes
@@ -95,7 +97,7 @@ TEST(LlvmLibcMBToWC, InvalidMultiByte) {
9597
ASSERT_TRUE(*dest == L'\0');
9698
}
9799

98-
TEST(LlvmLibcMBToWC, InvalidLastByte) {
100+
TEST_F(LlvmLibcMBToWCTest, InvalidLastByte) {
99101
// Last byte is invalid since it does not have correct starting sequence.
100102
// 0xC0 --> 11000000 starting sequence should be 10xxxxxx
101103
const char ch[4] = {static_cast<char>(0xF1), static_cast<char>(0x80),
@@ -107,7 +109,7 @@ TEST(LlvmLibcMBToWC, InvalidLastByte) {
107109
ASSERT_ERRNO_EQ(EILSEQ);
108110
}
109111

110-
TEST(LlvmLibcMBToWC, ValidTwoByteWithExtraRead) {
112+
TEST_F(LlvmLibcMBToWCTest, ValidTwoByteWithExtraRead) {
111113
const char ch[3] = {static_cast<char>(0xC2), static_cast<char>(0x8E),
112114
static_cast<char>(0x80)};
113115
wchar_t dest[2];
@@ -117,7 +119,7 @@ TEST(LlvmLibcMBToWC, ValidTwoByteWithExtraRead) {
117119
ASSERT_EQ(static_cast<int>(*dest), 142);
118120
}
119121

120-
TEST(LlvmLibcMBToWC, TwoValidTwoBytes) {
122+
TEST_F(LlvmLibcMBToWCTest, TwoValidTwoBytes) {
121123
const char ch[4] = {static_cast<char>(0xC2), static_cast<char>(0x8E),
122124
static_cast<char>(0xC7), static_cast<char>(0x8C)};
123125
wchar_t dest[2];
@@ -129,7 +131,7 @@ TEST(LlvmLibcMBToWC, TwoValidTwoBytes) {
129131
ASSERT_EQ(static_cast<int>(*(dest + 1)), 460);
130132
}
131133

132-
TEST(LlvmLibcMBToWC, NullString) {
134+
TEST_F(LlvmLibcMBToWCTest, NullString) {
133135
wchar_t dest[2] = {L'O', L'K'};
134136
// reading on nullptr should return 0
135137
int n = LIBC_NAMESPACE::mbtowc(dest, nullptr, 2);
@@ -141,7 +143,7 @@ TEST(LlvmLibcMBToWC, NullString) {
141143
ASSERT_EQ(n, 0);
142144
}
143145

144-
TEST(LlvmLibcMBToWC, NullWCPtr) {
146+
TEST_F(LlvmLibcMBToWCTest, NullWCPtr) {
145147
const char ch[2] = {
146148
static_cast<char>(0xC2),
147149
static_cast<char>(0x8E),

0 commit comments

Comments
 (0)