Skip to content

Commit 479c4d9

Browse files
committed
Revert changes in triple.
1 parent 4a063b8 commit 479c4d9

File tree

5 files changed

+4
-8
lines changed

5 files changed

+4
-8
lines changed

clang/lib/Driver/Driver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ inferOffloadToolchains(Compilation &C, Action::OffloadKind Kind) {
995995

996996
StringRef Triple;
997997
if (ID == OffloadArch::AMDGCNSPIRV)
998-
Triple = tools::AMDGCN::Linker::getSpirvBackendTriple();
998+
Triple = "spirv64-amd-amdhsa";
999999
else if (IsNVIDIAOffloadArch(ID))
10001000
Triple = C.getDefaultToolChain().getTriple().isArch64Bit()
10011001
? "nvptx64-nvidia-cuda"

clang/lib/Driver/ToolChains/HIPAMD.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
183183
if (UseSPIRVBackend) {
184184
llvm::opt::ArgStringList CmdArgs;
185185
const char *Triple =
186-
C.getArgs().MakeArgString("-triple=" + getSpirvBackendTriple());
186+
C.getArgs().MakeArgString("-triple=spirv64-amd-amdhsa");
187187
CmdArgs.append({"-cc1", Triple, "-emit-obj", LinkedBCFile.getFilename(),
188188
"-o", Output.getFilename()});
189189
const char *Exec = getToolChain().getDriver().getClangProgramPath();

clang/lib/Driver/ToolChains/HIPAMD.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ class LLVM_LIBRARY_VISIBILITY Linker final : public Tool {
3434
const llvm::opt::ArgList &TCArgs,
3535
const char *LinkingOutput) const override;
3636

37-
static constexpr StringRef getSpirvBackendTriple() {
38-
return "spirv64v1.6-amd-amdhsa";
39-
}
40-
4137
private:
4238
void constructLldCommand(Compilation &C, const JobAction &JA,
4339
const InputInfoList &Inputs, const InputInfo &Output,

clang/test/Driver/amdgpu-spirv-backend-opt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
// COM: Test that -amdgpu-use-experimental-spirv-backend calls clang -cc1 with the SPIRV triple.
44
// RUN: %clang -x hip %s --cuda-device-only --offload-arch=amdgcnspirv -amdgpu-use-experimental-spirv-backend -nogpuinc -nogpulib -### 2>&1 | FileCheck %s --check-prefix=CHECK-SPIRV-BACKEND
5-
// CHECK-SPIRV-BACKEND: "{{.*}}clang{{.*}}" "-cc1" "{{.*-triple=spirv64v[0-9]+\.[0-9]+-amd-amdhsa}}"
5+
// CHECK-SPIRV-BACKEND: "{{.*}}clang{{.*}}" "-cc1" "{{.*-triple=spirv64-amd-amdhsa}}"
66

77
// COM: Test that -no-amdgpu-use-experimental-spirv-backend calls the SPIRV translator
88
// RUN: %clang -x hip %s --cuda-device-only --offload-arch=amdgcnspirv -no-amdgpu-use-experimental-spirv-backend -nogpuinc -nogpulib -### 2>&1 | FileCheck %s --check-prefix=CHECK-SPIRV-TRANSLATOR

clang/test/Driver/hip-phases.hip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -700,6 +700,6 @@
700700
// SPIRV-ONLY-NEXT: 9: compiler, {8}, ir, (device-hip, amdgcnspirv)
701701
// SPIRV-ONLY-NEXT: 10: backend, {9}, ir, (device-hip, amdgcnspirv)
702702
// SPIRV-ONLY-NEXT: 11: linker, {10}, image, (device-hip, amdgcnspirv)
703-
// SPIRV-ONLY-NEXT: 12: offload, "device-hip (spirv64v1.6-amd-amdhsa:amdgcnspirv)" {11}, image
703+
// SPIRV-ONLY-NEXT: 12: offload, "device-hip (spirv64-amd-amdhsa:amdgcnspirv)" {11}, image
704704
// SPIRV-ONLY-NEXT: 13: linker, {6, 12}, hip-fatbin, (device-hip)
705705
// SPIRV-ONLY-NEXT: 14: offload, "device-hip (amdgcn-amd-amdhsa)" {13}, none

0 commit comments

Comments
 (0)