R4: Addressing review comments

Author: anchuraj

flang/include/flang/Frontend/CodeGenOptions.def

@@ -24,6 +24,8 @@ CODEGENOPT(OptimizationLevel, 2, 0) ///< The -O[0-3] option specified.
 CODEGENOPT(DebugPassManager, 1, 0) ///< Prints debug information for the new
                                    ///< pass manager.
 
+CODEGENOPT(InstrumentFunctions, 1, 0) ///< Set when -finstrument_functions is
+                                      ///< enabled on the compile step.
 CODEGENOPT(IsPIE, 1, 0) ///< PIE level is the same as PIC Level.
 CODEGENOPT(PICLevel, 2, 0) ///< PIC level of the LLVM module.
 CODEGENOPT(PrepareForFullLTO , 1, 0) ///< Set when -flto is enabled on the

flang/include/flang/Frontend/CodeGenOptions.h

@@ -81,9 +81,6 @@ class CodeGenOptions : public CodeGenOptionsBase {
   /// Options to add to the linker for the object file
   std::vector<std::string> DependentLibs;
 
-  /// Indicates whether -finstrument-functions is passed
-  bool InstrumentFunctions{false};
-
   // The RemarkKind enum class and OptRemark struct are identical to what Clang
   // has
   // TODO: Share with clang instead of re-implementing here

flang/lib/Frontend/CompilerInvocation.cpp

@@ -311,7 +311,7 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts,
     opts.OffloadObjects.push_back(a->getValue());
 
   if (args.hasArg(clang::driver::options::OPT_finstrument_functions))
-    opts.InstrumentFunctions = true;
+    opts.InstrumentFunctions = 1;
 
   // -flto=full/thin option.
   if (const llvm::opt::Arg *a =