Remove redundant lines of code and update comments

Author: Piyush Jaiswal

lldb/include/lldb/Target/Target.h

@@ -1348,14 +1348,14 @@ class Target : public std::enable_shared_from_this<Target>,
 
   /// Sends a breakpoint notification event if any listener is registered.
   /// \param[in] bp
-  ///     The breakpoint that was hit.
+  ///     The breakpoint to send a nofication for.
   /// \param[in] eventKind
   ///     The kind of event that occurred.
   void NotifyBreakpointChanged(Breakpoint &bp,
                                lldb::BreakpointEventType eventKind);
   /// Sends a breakpoint notification event if any listener is registered.
   /// \param[in] bp
-  ///     The breakpoint that was hit.
+  ///     The breakpoint that has changed.
   /// \param[in] data
   ///     The data associated with the event.
   void NotifyBreakpointChanged(Breakpoint &bp,

lldb/source/Breakpoint/Breakpoint.cpp

@@ -1100,9 +1100,6 @@ bool Breakpoint::EvaluatePrecondition(StoppointCallbackContext &context) {
 void Breakpoint::SendBreakpointChangedEvent(
     lldb::BreakpointEventType eventKind) {
   if (!IsInternal()) {
-    std::shared_ptr<BreakpointEventData> data =
-        std::make_shared<BreakpointEventData>(eventKind, shared_from_this());
-
     GetTarget().NotifyBreakpointChanged(*this, eventKind);
   }
 }

lldb/source/Breakpoint/BreakpointList.cpp

@@ -16,8 +16,7 @@ using namespace lldb;
 using namespace lldb_private;
 
 static void NotifyChange(const BreakpointSP &bp, BreakpointEventType event) {
-  Target &target = bp->GetTarget();
-  target.NotifyBreakpointChanged(*bp, event);
+  bp->GetTarget().NotifyBreakpointChanged(*bp, event);
 }
 
 BreakpointList::BreakpointList(bool is_internal)

lldb/source/Target/Target.cpp

@@ -5249,10 +5249,10 @@ void Target::DumpSectionLoadList(Stream &s) {
 void Target::NotifyBreakpointChanged(Breakpoint &bp,
                                      lldb::BreakpointEventType eventKind) {
   if (EventTypeHasListeners(Target::eBroadcastBitBreakpointChanged)) {
-    std::shared_ptr<Breakpoint::BreakpointEventData> data =
+    std::shared_ptr<Breakpoint::BreakpointEventData> data_sp =
         std::make_shared<Breakpoint::BreakpointEventData>(
             eventKind, bp.shared_from_this());
-    BroadcastEvent(Target::eBroadcastBitBreakpointChanged, data);
+    BroadcastEvent(Target::eBroadcastBitBreakpointChanged, data_sp);
   }
 }